Invert ISY994 dusk/dawn sensors to match expected state #92035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Dusk/Dawn nodes on Insteon Motion Sensors now have their states inverted to correctly show "Light detected" during daylight and "No light" when the dusk sensor is active. This is reversed from previous behavior and if you rely on this sensor in your automations, they will need to be updated.
Proposed change
As per #92001, [Insteon Motion Sensors 2842-222]((https://cache.insteon.com/documentation/2842-222-en.pdf) report Dusk to Dawn as "On" when light level is low (night) and "Off" when light levels are bright (day). In HA using the Universal Devices ISY/IoX integration this comes across and is showing up as a light class binary sensor but in that class the On and Off are reversed: On means light detected, Off means no light.
This change flips the state (like is already done for Moisture sensors) so it correctly matches the device class states in HA.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: