Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert ISY994 dusk/dawn sensors to match expected state #92035

Merged
merged 1 commit into from Apr 25, 2023

Conversation

shbatm
Copy link
Contributor

@shbatm shbatm commented Apr 25, 2023

Breaking change

Dusk/Dawn nodes on Insteon Motion Sensors now have their states inverted to correctly show "Light detected" during daylight and "No light" when the dusk sensor is active. This is reversed from previous behavior and if you rely on this sensor in your automations, they will need to be updated.

Proposed change

As per #92001, [Insteon Motion Sensors 2842-222]((https://cache.insteon.com/documentation/2842-222-en.pdf) report Dusk to Dawn as "On" when light level is low (night) and "Off" when light levels are bright (day). In HA using the Universal Devices ISY/IoX integration this comes across and is showing up as a light class binary sensor but in that class the On and Off are reversed: On means light detected, Off means no light.

This change flips the state (like is already done for Moisture sensors) so it correctly matches the device class states in HA.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (isy994) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of isy994 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign isy994 Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco merged commit 969db34 into home-assistant:dev Apr 25, 2023
26 checks passed
@bdraco
Copy link
Member

bdraco commented Apr 25, 2023

Thanks @shbatm

@shbatm shbatm deleted the isy994_dusk branch April 25, 2023 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insteon Motion Sensors 2842-222 Dusk-to-Dawn node showing reversed in binary sensor
2 participants