Entities hidden by an integration cannot be disabled/enabled by a user

[dermotduffy]

Checklist

• I have updated to the latest available Home Assistant version.
• I have cleared the cache of my browser.
• I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

When an integration has an entity that is hidden by default (e.g.):

  self._attr_entity_registry_visible_default = False

The UI appears to not allow the user to enable (which presumable also unhides it) or disable it. Note how the controls are disabled in the below screenshot:

This appears to be intentional (source, written by @zsarnett ). It's unclear why this is desirable as effectively this means if an integration lists any entity as hidden, it can never be unhidden or disabled by the user via these controls -- but I suppose this could be WAI if integrations are not expected to hide entities that the user could subsequently unhide / enable / disable.

For my usecase (Frigate), allowing a user to disable entities is occasionally useful, so this would deter my usage of hidden entities at all.

Related PR: blakeblackshear/frigate-hass-integration#273

Describe the behavior you expected

The HA frontend should allow entities hidden by an integration to be disabled or unhidden.

Steps to reproduce the issue

1. Use any integration that creates hidden entities (or just set hidden_by for an entity registry entry to integration).
2. Navigate to the entity: Settings -> Devices & Services -> Entities Tab
3. Ensure Show hidden entities is selected in the filter.
4. Open the hidden entity
5. Open the Advanced Settings expansion panel.

Observe Enabled / Hidden / Disabled controls are all disabled.

What version of Home Assistant Core has the issue?

2022.7.0.dev20220604

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Google Chrome 101.0.4951.54 (Official Build) (64-bit)

Which operating system are you using to run this browser?

Ubuntu 20.04.3 LTS

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

[github-actions]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[felipecrs]

I would say that this issue is still valid.

[felipecrs]

@zsarnett can you please help us understand the reasoning behind it? Or would you accept a PR changing this behavior?

[austwhite]

Just weighing in on this. An Integration can disable an entity, but this is meant to be fully under our control. If we decide we want to expose an entity, we should be allowed to do so. We always were allowed to re-enable entities until recently.
An example I have is an Aqara Motion Sensor. It has motion and occupancy. The motion entitiy is hidden by the integration, and I want that to be fully exposed as I don't use the "occupancy" entity.
Thanks :)

[github-actions]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[felipecrs]

I believe this is still relevant.

[someonewating]

Do you have any temporary solution?

[github-actions]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[NickM-27]

Bump

[karwosts]

@NickM-27 - are you sure this is still valid?

I checked entity hidden by integration and it allows me to enable/disable it with the toggle.

Suggest this to be closed unless you have a counterexample.

[NickM-27]

This screenshot is missing the most important part which is the visibility switch.

Not with my computer to test, can do that later next week

[karwosts]

This screenshot is missing the most important part which is the visibility switch.

Not with my computer to test, can do that later next week

Ok I understand what you mean now. Yes the visibility switch is still disabled. The PR title said you can't enable/disable the entity, so I was focused on the Enabled switch.

I was going to say that I didn't think the backend supported users overriding hidden by integration visibility, though just now I tried it on a chance and it did seem to take effect. I'll look into this a bit more and see if that's really possible or not.

[karwosts]

On inspection I can't see any reason why we would not allow user to override visibility for entity hidden by integration. It seems supported fine in the backend.

I have rolled a fix for this into an existing PR I had for visibility settings.

[NickM-27]

That's awesome 👌