Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History-graph: do not make a graph for "unavailable" sensor transparent #14731

Closed
3 tasks done
ildar170975 opened this issue Dec 13, 2022 · 9 comments
Closed
3 tasks done

Comments

@ildar170975
Copy link
Contributor

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

Since 2022.12.4 a graph for "unavailable" entity is shown of transparent color.
image

This is confusing:

  1. No graph for some entity may be considered as bug.
  2. Transparent color = gap, but currently a gap is displayed in cases when an entity does not exist.

And when within the selected period the entity is unavailable - then no graph is displayed at all:
image
which is super-confusing.

Describe the behavior you expected

Graph for "unavailable" sensor must not be transparent.
Better to use some theme variable like --history-state-color-unavalailable.

Steps to reproduce the issue

as above

What version of Home Assistant Core has the issue?

2022.12.4

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Chrome 108.0.5359.99

Which operating system are you using to run this browser?

Win10x64

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@matthiasdebaat
Copy link
Collaborator

Since 2022.12.4 a graph for "unavailable" entity is shown of transparent color. image

This is confusing:

  1. No graph for some entity may be considered as bug.
  2. Transparent color = gap, but currently a gap is displayed in cases when an entity does not exist.

What can be considered as a bug is that we don't show a label.

Like I said earlier: unavailable being transparant communicates a correct message, saying it's not a value like on, off, clear, etc. It's not that common an entity doesn't exist, only a first time. Note that your example is of 4 minutes, that's not a regular use case in my opinion.

And when within the selected period the entity is unavailable - then no graph is displayed at all: image which is super-confusing.

That isn't consistent indeed. We should keep the same design pattern.

@ildar170975
Copy link
Contributor Author

ildar170975 commented Dec 13, 2022

communicates a correct message,

But many people in Community disagree.

Also, since currently you implemented a "color for icon = color for history" way for domains -> are you going to make a transparent icon for unavailable entities too? ))
Not to mention a fact that your change to transparent just breaks people's expectations like "I see grey - means unavailable".

It's not that common an entity doesn't exist, only a first time.

Unclear, what do you mean?
The "entity does not exist" is a very common case.
Especially when HA is on development stage (which may be a permanent state for some people).

Note that your example is of 4 minutes, that's not a regular use case in my opinion.

Not sure what "4 minutes" you are talking about. But if you mean the 1st screenshot - this is a test case which is used for testing (a term we are missing a lot). And this case demonstrates an issue.

@ChristophCaina
Copy link

I have to disagree to the following statement:

It's not that common an entity doesn't exist, only a first time.

unfortunately, "Unknown" happene every time, when you have a cloud-based integration and the connection could not be established - or, if the integration could not be loaded, or similar...

Let me show you an example:
grafik

While I can fully agree with missing information in the Graph -> no data to record at all, the STATE should at least indicate SOME information.

Unfortunately, with only a lable, it does not work in all cases, because probably, on several occurances there's not the required space to write the label.

@ildar170975
Copy link
Contributor Author

A label on a transparent bar may be not even noticeable.
Not to mention already described reasons like

  • absence of a graph treated by many people as a bug;
  • will not be possible to distinguish unavailable case & "does not exist" case;
  • since icon color = history color, it is meaningless to use transparent icon color for unavailable.

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 13, 2023
@ildar170975
Copy link
Contributor Author

up

@github-actions github-actions bot removed the stale label Mar 13, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 11, 2023
@ildar170975
Copy link
Contributor Author

up

@github-actions github-actions bot removed the stale label Jun 11, 2023
@ildar170975
Copy link
Contributor Author

May be closed - as long as --history-unavailable-color var is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants