Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost draggable dot on thermostats #15662

Closed
3 tasks done
krzysztofsk opened this issue Mar 1, 2023 · 19 comments · Fixed by #15670
Closed
3 tasks done

Lost draggable dot on thermostats #15662

krzysztofsk opened this issue Mar 1, 2023 · 19 comments · Fixed by #15670

Comments

@krzysztofsk
Copy link

krzysztofsk commented Mar 1, 2023

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

Can't change temperature on thermostat card. Dot is missing.
Zrzut ekranu 2023-03-1 o 21 36 53

Describe the behavior you expected

Thermostat dot should be visible and draggable.

Steps to reproduce the issue

  1. Use thermostat card

What version of Home Assistant Core has the issue?

2023.3.0

What was the last working version of Home Assistant Core?

2023.2.5

In which browser are you experiencing the issue with?

Chrome, HA companion app Android

Which operating system are you using to run this browser?

MacOS Ventura 13.2.1

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@krzysztofsk
Copy link
Author

Same for lights

@karwosts
Copy link
Contributor

karwosts commented Mar 1, 2023

+1, chrome & firefox, win10

There's still something there, when the mouse hovers over where the dot should be it changes from the pointer to the clicky-hand icon. If I try to click, I get this exception:

eb71732c.js:2 Uncaught TypeError: Cannot read properties of null (reading 'classList')
    at s.dragStart (eb71732c.js:2:25186)
    at z.handleEvent (styles.ts:353:1)

@ChristophCaina
Copy link

ChristophCaina commented Mar 1, 2023

+1 chrome, Windows 10 and I can confirm the error in the logs

Logger: frontend.js.latest.202303010
Source: components/system_log/__init__.py:254
First occurred: 00:09:08 (8 occurrences)
Last logged: 00:30:18

https://******/frontend_latest/eb71732c.js:2:25186 Uncaught TypeError: Cannot read properties of null (reading 'classList')

@karwosts
Copy link
Contributor

karwosts commented Mar 1, 2023

My core/development install doesn't exhibit this (fetched frontend:master and core:master), but my normal HAOS install does.

@balloob
Copy link
Member

balloob commented Mar 2, 2023

99% sure this is because of HTML minifying. CC @steverep

@steverep
Copy link
Member

steverep commented Mar 2, 2023

Yeah probably. I'll check it out.

@steverep
Copy link
Member

steverep commented Mar 2, 2023

Does this seem to be a problem on all <round-slider> elements or just thermostat?

@karwosts
Copy link
Contributor

karwosts commented Mar 2, 2023

Light card is also missing.

image

@3ative
Copy link

3ative commented Mar 2, 2023

In case it's relevant, the "Dots" are missing on an ESPHome Thermostat too
image

@steverep
Copy link
Member

steverep commented Mar 2, 2023

I think this has to do with SVG minification but when I examine the minified code, nothing is jumping out as wrong.

@karwosts can you confirm the visual problem appears in development if you change line 116 of bundle.js to:

    /* isProdBuild && */ [

This will enable minification temporarily for development.

@karwosts
Copy link
Contributor

karwosts commented Mar 2, 2023

@karwosts can you confirm the visual problem appears in development if you change line 116 of bundle.js to:

    /* isProdBuild && */ [

This will enable minification temporarily for development.

Yes, I confirm that. Once I added that comment, it broke my dev instance the same as the production one.

@steverep
Copy link
Member

steverep commented Mar 2, 2023

Thanks for the quick reply. I fixed it. PR is coming.

@steverep
Copy link
Member

steverep commented Mar 2, 2023

I just linked a PR. If you want to double-check the fix, make sure to add that comment again.

@pedromfa
Copy link

pedromfa commented Mar 2, 2023

Same issue here with the thermostat... Any fix?

@piitaya
Copy link
Member

piitaya commented Mar 2, 2023

Same issue here with the thermostat... Any fix?

The fix will be deploy with the 2023.3.1 core release.

@jenshenk
Copy link

jenshenk commented Mar 2, 2023

Great news, I was already afraid I need to cope with this for a couple of weeks after updating to 3.0 only for the yellow lights :)

@artblue1
Copy link

artblue1 commented Mar 2, 2023

fixed with 2023.3.1

@jenshenk
Copy link

jenshenk commented Mar 2, 2023

Amazing, thanks so much!

@GeorgeRT
Copy link

GeorgeRT commented Mar 3, 2023

Did a Quick Reload to effect fix. Thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.