-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent dialog when deleting tag #21240
Comments
As the tag would still exist after you remove it from Home Assistant, we should change the button tot |
So we should use "remove" because the tag still physically exists or did I misunderstand that? |
Correct |
I'm not sure if I would follow for that reason to make it "remove". It still deletes the tag from Home Assistant in a non recoverable way. "remove" mentions it is kept in existence, which means it's still somewhere around but no longer associated or referenced. |
I've researched it a bit more and come to the following conclusion:
Added this to our design docs #21297 In this case, you can add the tag again. It's recoverable, so it can be Remove. I can live with both. |
I've opened a pull request for "delete" if you don't mind. Reading the design doc, I still interpret "delete" as delete everything that is known to the tag while "remove" to me is clear the associations, but keep the tag present in Home Assistant. |
After reading these resources below, it follows your previous/current design documentation with the addition that "remove" can also be used if you delete something to the trash can, which means it can be undone and thus recoverable. |
Checklist
Describe the issue you are experiencing
When deleting a tag, it has red "Delete" button at first (good)
![Screen Shot 2024-07-01 at 3 05 55 AM](https://private-user-images.githubusercontent.com/9065557/344577694-a0e4ede8-c96e-4e46-9caf-9f641abd5abf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MDAwNjcsIm5iZiI6MTcyMDU5OTc2NywicGF0aCI6Ii85MDY1NTU3LzM0NDU3NzY5NC1hMGU0ZWRlOC1jOTZlLTRlNDYtOWNhZi05ZjY0MWFiZDVhYmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTBUMDgyMjQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWM2NGRlOGM4ZTQzY2QzZjk3ZDFlZGVjOWMyYjExMzc3OWQ2YmNiYzQzN2I0ZGYzYTg1Mzc4YWQxY2U4OWRhYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.-SMLshUllyaE0RlpZQMTo0MXKUfctVjNsO7fzmdu8J8)
But then confirmation prompt shows it as "Remove" button and without red text
![Screen Shot 2024-07-01 at 3 06 01 AM](https://private-user-images.githubusercontent.com/9065557/344577755-15ef716b-41fe-4cc4-8de6-5ff361f8ffeb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MDAwNjcsIm5iZiI6MTcyMDU5OTc2NywicGF0aCI6Ii85MDY1NTU3LzM0NDU3Nzc1NS0xNWVmNzE2Yi00MWZlLTRjYzQtOGRlNi01ZmYzNjFmOGZmZWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTBUMDgyMjQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTk5NWVjYjJiYWZjMjYwYTU5MzBlYWM4ZTFmZTFlNGEyZjg0NDIzNGEwMmEzZTkzYTZjYmU4OTRmOGQ2MWYxZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.L46AGKut9_QPFel5E_wdz6243yX0aiNM2UBjHM5j3BQ)
Describe the behavior you expected
Consistent wording (Delete), and red text on confirmation prompt
Steps to reproduce the issue
What version of Home Assistant Core has the issue?
2024.7.0b6
What was the last working version of Home Assistant Core?
No response
In which browser are you experiencing the issue with?
No response
Which operating system are you using to run this browser?
No response
State of relevant entities
No response
Problem-relevant frontend configuration
No response
Javascript errors shown in your browser console/inspector
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: