Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode unreadable for some items #6622

Closed
G8YTZ opened this issue Aug 14, 2020 · 6 comments · Fixed by #6694
Closed

Dark Mode unreadable for some items #6622

G8YTZ opened this issue Aug 14, 2020 · 6 comments · Fixed by #6694
Labels
Bug Current Bug in UI - Extra Attention

Comments

@G8YTZ
Copy link

G8YTZ commented Aug 14, 2020

  1. Cover indications don't show grey/white in "dark" mode (comparison shown in light and dark modes)
  2. Maps unreadable in "dark" mode.

Examples below (shown on Safari, iPhone app is the same)

IMG_1293
IMG_1292
Screenshot 2020-08-14 at 22 21 38

@G8YTZ G8YTZ added the Bug Current Bug in UI - Extra Attention label Aug 14, 2020
@jellevervloessem
Copy link

I noticed also that on the Cover, the arrows are hard to distinguish. If a cover is open, it's up-arrow is gray, and the down-arrow is black:
image
In Dark mode, its hard distinguish:
image

@bramkragten
Copy link
Member

bramkragten commented Aug 25, 2020

For the dark mode map, we use these https://carto.com/help/building-maps/basemap-list/#carto-raster-basemaps so there is not much we can do there.

@skandalfo
Copy link

The dark-mode maps are what breaks the dark theme for me. No contrast at all.

Can this be fixed by some liberal application of the CSS "filter" property?

e.g.: This, applied via the dev console in Chrome:

filter: invert(1) brightness(2.8) contrast(1.2);

Automatically made OSM from the light theme look "dark", but still way more readable than the current dark theme.

My hacking around meant that the overlays got filtered too, but I'm assuming that can be fixed with some work?

@barrymossel
Copy link

Nothing on this? The map in dark mode is almost unusable...

@avviano
Copy link

avviano commented Jul 11, 2021

I really love the dark UI in Home Assistant! Seriously Awesome!!!

... But the map in Dark Mode is totally unusable. Why would anyone want an unreadable map by default? Makes no sense really. I think this is a classic example of "Form follows Function" gone terribly wrong.

As a fix I propose either to make the map lighter (so we can CLEARLY distinguish features) or make option available to set to "normal" or "white" or "color".

Always remember "Form (design) follows funtion" not the other way round.

Keep up the good work!
Cheers

@bramkragten
Copy link
Member

If someone finds some nice dark mode tiles for Leaflet that we are allowed to use, we are very much open to that. Please continue this discussion in #9493, as this issue is closed.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Current Bug in UI - Extra Attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants