Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Automatic shell linter for PR #110

Closed
ludeeus opened this issue Feb 13, 2018 · 1 comment
Closed

Automatic shell linter for PR #110

ludeeus opened this issue Feb 13, 2018 · 1 comment
Assignees
Projects

Comments

@ludeeus
Copy link
Member

ludeeus commented Feb 13, 2018

https://stickler-ci.com/docs#bash
Can be activated on this repo to automatically check for common mistakes in shell scripts.
Before activating all existing scripts must be validated.

@ludeeus ludeeus created this issue from a note in v0.8.0 (To do) Feb 13, 2018
@ludeeus ludeeus moved this from To do to In progress in v0.8.0 Feb 13, 2018
@ludeeus ludeeus self-assigned this Feb 13, 2018
@ludeeus
Copy link
Member Author

ludeeus commented Feb 13, 2018

All scripts are now compliant for Stickler-CI.
There is 1 issue remaining:

In package/opt/hassbian/suites/homebridge.sh line 64:
RANDOM_MAC=$( for i in {1..6} ; do echo -n ${HEX_CHARS:$((RANDOM % 16)):1} ; done | sed -e 's/\(..\)/:\1/g' )
              ^-- SC2034: i appears unused. Verify it or export it.

Line in question
Docs for SC2034, not sure how to handle that one, @Landrash do you have an idea?

v0.8.0 automation moved this from In progress to Done Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v0.8.0
  
Done
Development

No branches or pull requests

1 participant