Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to use SSH as webterminal only #1117

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Support to use SSH as webterminal only #1117

merged 1 commit into from
Feb 20, 2020

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 20, 2020

Fix: #1116

recommended by @balloob

@pvizeli pvizeli marked this pull request as ready for review February 20, 2020 09:49
@pvizeli pvizeli merged commit 2df8425 into master Feb 20, 2020
@pvizeli pvizeli deleted the webterminal-only branch February 20, 2020 09:49
rct
rct reviewed Feb 22, 2020
View reviewed changes
Copy link

@rct rct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was already merged, but a few comments for thought about this change.

ssh/README.md Show resolved Hide resolved
ssh/config.json Show resolved Hide resolved
ssh/config.json Show resolved Hide resolved
@home-assistant home-assistant locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rct rct rct left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH addon should be able to start with default config.
4 participants
@pvizeli @rct @frenck @homeassistant