deconz: Add LEDVANCE / OSRAM otau firmware downloader #983

olijouve · 2020-01-06T13:24:00Z

Add LEDVANCE / OSRAM otau firmware downloader, respecting max 10 DL per minute Ratelimits

resolves #985

olijouve · 2020-01-07T13:17:07Z

Can you make one PR with your change + changelog and update the version number in that PR. Thanks!

@pvizeli, I think that PR do respect what you asked me to rectify on my previous PRs ?
I closed them by the way.

pvizeli · 2020-01-07T15:19:52Z

Please address the lint issue. The script have the correct permission of a+x?

Fix lint issues: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2003 -- expr is antiquated. Consider rewr...

Fix lint issue: https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...

@pvizeli

Adressing @pvizeli comment : The script have the correct permission of a+x? Add CMD to set a+x permission on ledvance-otau-dl.sh script

olijouve · 2020-01-08T09:49:44Z

Please address the lint issue. The script have the correct permission of a+x?

it's done

frenck · 2020-01-08T10:09:16Z

deconz/Dockerfile

 COPY data/nginx.conf /etc/nginx/nginx.conf
 COPY data/run.sh data/discovery.sh /

-CMD ["/run.sh"]
+CMD ["/bin/chmod a+x /bin/ledvance-otau-dl.sh && /run.sh"]


Setting permissions should be either in the Docker build or just ensure it is correctly set into the repository. Either way, not in the RUN command.

Ok sorry, i’ll look to fix that this evening.

Between that two methods, does there is one to be prefered ?

I prefer to use git-index: git update-index --chmod=+x path-name-shell-script So you need just copy the file on docker build like the other scripts

homeassistant · 2020-01-08T16:38:24Z

Hello @olijouve,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

59aaf1cb3799f48f607c0669a30878208aa54081 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.
3f830164e0d78b35e5cab46b24917a16c51674c1 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

homeassistant · 2020-01-08T18:09:05Z

Hello @olijouve,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

59aaf1cb3799f48f607c0669a30878208aa54081 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.
3f830164e0d78b35e5cab46b24917a16c51674c1 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

remove dummy comment

homeassistant · 2020-01-08T18:14:37Z

Hello @olijouve,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

59aaf1cb3799f48f607c0669a30878208aa54081 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.
3f830164e0d78b35e5cab46b24917a16c51674c1 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

remove dummy comment

homeassistant · 2020-01-08T18:15:02Z

Hello @olijouve,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

59aaf1cb3799f48f607c0669a30878208aa54081 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.
3f830164e0d78b35e5cab46b24917a16c51674c1 - This commit has something that looks like an email address (ojouve@macbook-pro-de-olivier.local). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

olijouve · 2020-01-08T18:21:10Z

@pvizeli, @frenck, thank you for your patience, i'm pretty bad using git and docker :-/
This one was the good one i think(...and hope :)

frenck · 2020-01-09T13:29:21Z

@olijouve You need to fix the CLA errors as described in the bot's comment. Could you take care of that? 👍

olijouve · 2020-01-09T16:04:14Z

@olijouve You need to fix the CLA errors as described in the bot's comment. Could you take care of that? 👍

I tried and wasn't able to fix it 😓 the mail adress was an @hostname.local so email verification never succeeded, also script method failed then it was too much skilled for me.

olijouve · 2020-01-09T16:05:13Z

Thanks to both of you !

oncleben31 · 2020-01-09T22:48:46Z

Thank you for your PR. I was expecting to find a way to put firmware in the container.
From what I understand your script will download all the firmwares from Ledevance website. It is a good MVP. DO you think it could be improve in the future to perhaps use a setting to only download chosen firmware?

frenck · 2020-01-10T08:08:05Z

@oncleben31, that is out of scope for this PR, besides, it the behavior we currently use for other vendors as well.

oncleben31 · 2020-01-10T08:58:58Z

OK great. I didn't expect a take it into account in this PR. Just for the discussion ;-)
Great job.
Waiting the merge and the next add-on release.

@pvizeli

…#983) * Update config.json * Create ledvance-otau-dl.sh * Update run.sh * Update Dockerfile * Update CHANGELOG.md * Update CHANGELOG.md * Update ledvance-otau-dl.sh Fix lint issues: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2003 -- expr is antiquated. Consider rewr... * Update ledvance-otau-dl.sh Fix lint issue: https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti... * Update Dockerfile Adressing @pvizeli comment : The script have the correct permission of a+x? Add CMD to set a+x permission on ledvance-otau-dl.sh script * Update Dockerfile * Add exec permissions * revert oups bad multiple cmdlines in CMD[] * revert oups bad multiple cmdlines in CMD[] * dummy commit * Update Dockerfile remove dummy comment * Update ledvance-otau-dl.sh remove dummy comment * fix bug Co-authored-by: Pascal Vizeli <pascal.vizeli@syshack.ch>

olijouve added 6 commits January 6, 2020 14:15

Update config.json

6df2611

Create ledvance-otau-dl.sh

fead67e

Update run.sh

8ef487c

Update Dockerfile

680a80c

Update CHANGELOG.md

17360f5

Update CHANGELOG.md

d274e84

homeassistant added the cla-signed label Jan 6, 2020

olijouve mentioned this pull request Jan 6, 2020

deconz: Create ledvance-otau-dl.sh #979

Closed

frenck mentioned this pull request Jan 8, 2020

deCONZ add a way to upload firmware binaries in the container for OTA Zigbee device update #985

Closed

olijouve added 4 commits January 8, 2020 10:24

Update ledvance-otau-dl.sh

211e168

Fix lint issues: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2003 -- expr is antiquated. Consider rewr...

Update ledvance-otau-dl.sh

2680749

Fix lint issue: https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...

Update Dockerfile

795abd4

Adressing @pvizeli comment : The script have the correct permission of a+x? Add CMD to set a+x permission on ledvance-otau-dl.sh script

Update Dockerfile

397f785

frenck reviewed Jan 8, 2020

View reviewed changes

Olivier JOUVE added 2 commits January 8, 2020 17:33

Add exec permissions

3f83016

revert oups bad multiple cmdlines in CMD[]

59aaf1c

homeassistant added the cla-error label Jan 8, 2020

olijouve and others added 3 commits January 8, 2020 17:47

revert oups bad multiple cmdlines in CMD[]

289caa8

Merge branch 'master' of https://github.com/olijouve/hassio-addons

fbe0047

dummy commit

785a0d3

Update Dockerfile

f694c81

remove dummy comment

Update ledvance-otau-dl.sh

f53181f

remove dummy comment

fix bug

d38c306

pvizeli approved these changes Jan 9, 2020

View reviewed changes

pvizeli merged commit 6847f76 into home-assistant:master Jan 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deconz: Add LEDVANCE / OSRAM otau firmware downloader #983

deconz: Add LEDVANCE / OSRAM otau firmware downloader #983

olijouve commented Jan 6, 2020 •

edited by frenck

olijouve commented Jan 7, 2020

pvizeli commented Jan 7, 2020

olijouve commented Jan 8, 2020

frenck Jan 8, 2020

olijouve Jan 8, 2020

olijouve Jan 8, 2020

pvizeli Jan 8, 2020 •

edited

frenck Jan 8, 2020

homeassistant commented Jan 8, 2020

homeassistant commented Jan 8, 2020

homeassistant commented Jan 8, 2020

homeassistant commented Jan 8, 2020

olijouve commented Jan 8, 2020

frenck commented Jan 9, 2020

olijouve commented Jan 9, 2020 •

edited

olijouve commented Jan 9, 2020

oncleben31 commented Jan 9, 2020

frenck commented Jan 10, 2020

oncleben31 commented Jan 10, 2020

deconz: Add LEDVANCE / OSRAM otau firmware downloader #983

deconz: Add LEDVANCE / OSRAM otau firmware downloader #983

Conversation

olijouve commented Jan 6, 2020 • edited by frenck

olijouve commented Jan 7, 2020

pvizeli commented Jan 7, 2020

olijouve commented Jan 8, 2020

frenck Jan 8, 2020

Choose a reason for hiding this comment

olijouve Jan 8, 2020

Choose a reason for hiding this comment

olijouve Jan 8, 2020

Choose a reason for hiding this comment

pvizeli Jan 8, 2020 • edited

Choose a reason for hiding this comment

frenck Jan 8, 2020

Choose a reason for hiding this comment

homeassistant commented Jan 8, 2020

homeassistant commented Jan 8, 2020

homeassistant commented Jan 8, 2020

homeassistant commented Jan 8, 2020

olijouve commented Jan 8, 2020

frenck commented Jan 9, 2020

olijouve commented Jan 9, 2020 • edited

olijouve commented Jan 9, 2020

oncleben31 commented Jan 9, 2020

frenck commented Jan 10, 2020

oncleben31 commented Jan 10, 2020

olijouve commented Jan 6, 2020 •

edited by frenck

pvizeli Jan 8, 2020 •

edited

olijouve commented Jan 9, 2020 •

edited