Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images no longer shown in notification (latest build) #362

Closed
Swiftnesses opened this issue May 10, 2019 · 52 comments
Closed

Images no longer shown in notification (latest build) #362

Swiftnesses opened this issue May 10, 2019 · 52 comments

Comments

@Swiftnesses
Copy link

@robbiet480 Just testing some new flows in Node Red and I've noticed that push messages with image_url no longer show the image...

Example:

    image_url: "https://www.test.com.jpg",
    image_type: "jpg"
@robbiet480
Copy link
Member

@Swiftnesses That isn’t a valid URL, maybe that’s why?

@Swiftnesses
Copy link
Author

@Swiftnesses That isn’t a valid URL, maybe that’s why?

@robbiet480 It was a terrible example, my actual URL is valid 👍

@TomBrien
Copy link
Member

@Swiftnesses can you post your full automation/script here, with an reactions you need to make for privacy?

@Swiftnesses
Copy link
Author

Swiftnesses commented May 10, 2019

I use node red, but basically I'm passing this:

msg.ios_notification = 
{ 
    title: "Duck Coop - Door Opened", 
    message: "The door has been opened, please check the image.",
    image_url: "http://192.168.1.48:8090/webcam/a94df035fc91a158c1f9d7a1c769ca66/a94df035fc91a158c1f9d7a1c769ca66_raw.jpg",
    image_type: "jpg",
    target: "both"
};

This has worked until a recent build (not sure which!).

Edit, I must point out that the above is sent as:

{
    "title": "{{{ ios_notification.title }}}",
    "message": "{{{ ios_notification.message }}}",
    "data": {
        "push": {
            "category": "{{{ ios_notification.category }}}"
        },
        "attachment": {
            "url": "{{{ ios_notification.image_url }}}",
            "content-type": "{{{ ios_notification.image_type }}}",
            "hide-thumbnail": "{{{ ios_notification.hide_thumbnail }}}"
        }
    }
}

@Swiftnesses
Copy link
Author

Normal push notifications work fine, including push categories (buttons), it's the image display that's stopped working...

@TomBrien
Copy link
Member

I'm not hugely familiar (ok at all) with node red but are you possibly missing a value for hide-thumbnail anywhere or are this and category defined elsewhere?

@Swiftnesses
Copy link
Author

Hi @TomBrien this is optional and in my test, I don't pass it...

@TomBrien
Copy link
Member

TomBrien commented May 10, 2019

Ok. I'm seeing that images behind a https url aren't working. Not sure if that's going to prove to be related

None https urls are about 50/50 for me. Literally just pressing call service 4 times back to back gave me two with image to without. I wonder if it is a timeout for HA to grab the image or something?

@Swiftnesses
Copy link
Author

I'm not entirely sure, but this worked flawlessly before, so something has changed, sadly, I'm not sure what...

The images are also coming via my local network and the grab time is in the milliseconds...

@vandalon
Copy link

I can confirm image no longer working in notifications after build 55.
I've tested all builds after 55 from 58 downwards. (I upgraded from 54 to 58, then i noticed the pictures not working. I then tried 57and 56 and noticed the same issue. Then installed 55 and all was good again.

This is the json a insert into home assistant.

{"message":"Ding Dong!","data":{"push":{"category":"camera","sound":{"critical":1,"name":"default"}},"entity_id":"camera.voordeur"}}

@TomBrien
Copy link
Member

In build 58 I still have 0 % delivery of https attachments and about 50 % with http

@rpcaeiro
Copy link

Exactly the same issue here. Build 58 fails a lot. Version 1.5 never fails and the image is always in the notification.

@giuarb
Copy link

giuarb commented May 21, 2019

Same here.....

@tinglis1
Copy link

I think i am having the same issue.
I have one node-red automation that sends an image to my phone with the beta and it isn't getting the images. The same notification sent to another phone running the old app is getting the image.
my image is using the duckdns link but have also tried the nabu casa link with no change.

I have also tested with the example from the documentation without success either.
https://www.home-assistant.io/docs/ecosystem/ios/notifications/attachments/

@Swiftnesses
Copy link
Author

This is a killer, think for now I'm going to roll back to the old mobile build...

@vandalon
Copy link

I can confirm this issue still exist in build 59

@giuarb
Copy link

giuarb commented May 29, 2019

picture notification is one of the best features of the app, just installed version 60 and it doesn't look it is working but I will double check once home

@robbiet480
Copy link
Member

Working on this tonight.

@vandalon
Copy link

You sir, are awesome

@giuarb
Copy link

giuarb commented Jun 2, 2019

it may be more complicated than thought.
Which was the last working version for notification?

@vandalon
Copy link

vandalon commented Jun 2, 2019

Build 55 works perfectly, 56 doesn't :)

@giuarb
Copy link

giuarb commented Jun 6, 2019

I am back on the 55 and works like a charm! also my apple watch shows the picture

@mountainsandcode
Copy link

Hi @robbiet480, what can we do to help on the debugging of this issue?
I’ve tried a few different setups but haven’t concluded anything other than the fact that on https it almost never works, on http it’s hit and miss.
Could it be some kind of timeout that the app runs into when trying to download the image?

@giuarb
Copy link

giuarb commented Jun 13, 2019

I am also available for help
Still on 55 all works

@PDekker
Copy link

PDekker commented Jun 16, 2019

Same here. Is it related to the stream component?

@giuarb
Copy link

giuarb commented Jun 16, 2019

Same here. Is it related to the stream component?

revert to 55, all works then.
This app should be a paid one like zone ninja for zoneminder, this would allow great people to work on it.
I wouldn't mind paying for it

robbiet480 added a commit that referenced this issue Jun 18, 2019
@tinglis1
Copy link

@giuarb
You can support Robbie through Patreon
https://www.patreon.com/robbiet480/overview

@giuarb
Copy link

giuarb commented Jun 19, 2019

@giuarb
You can support Robbie through Patreon
https://www.patreon.com/robbiet480/overview

I will

@giuarb
Copy link

giuarb commented Jun 19, 2019

Installed version 60 but notification isn't working at all (of course I did the import push.....)

@robbiet480
Copy link
Member

@giuarb Can you please share the payload you are sending?

@tinglis1
Copy link

@giuarb isn’t the latest version 61?

@robbiet480
Copy link
Member

Oh good catch @tinglis1, yes, @giuarb, the latest version is 61.

@tinglis1
Copy link

FYI, I have tested it and it is working for me with v61.

@giuarb
Copy link

giuarb commented Jun 19, 2019

sorry it is the 61, I have removed the 55, installed the 61, ,enabled auth for notifications, import push
I don't get any notification at all.
I have installed from remote by entering the duckdns https url

@vandalon
Copy link

For me the issues seems to be resolved with build 61. Great work Robbie!

@vandalon
Copy link

I do notice that sometimes the picture that is shown in the banner is not always shown. I had this in build 55 as well. It does not happen often but sometimes and it seems random.

@vandalon
Copy link

vandalon commented Jun 24, 2019

It seems that images are still not always sent in the 2.0 app, where as the same notification always gives an image on the 1.x version. (my girlfriend is still running the 1.x app). I can't say when it happens and when not. seems random. Does the 1.x version also use firebird? Because I see this behaviour also in the zoneminder notification script which also uses firebird.

@rpcaeiro
Copy link

Exactly the same here as vandalon

@vandalon
Copy link

vandalon commented Jul 5, 2019

I have about 50% succes rate :) (all notifications here should have images).

Maybe it's ok to re-open this issue?

image

@JohannPie
Copy link

JohannPie commented Aug 27, 2019

Build 62 and no Images for me
Edit: Downgraded to 61, and then updated back to 62 seems to fix the issue

@vandalon
Copy link

Since today it seems no image is getting trough and also camera live view no longer works. Both work perfectly in the old (1.5) app.

@TomBrien
Copy link
Member

This is a known bug that sneaked in with b63. Plan is to release a new build in the coming days.

@TomBrien TomBrien reopened this Sep 19, 2019
@vandalon
Copy link

This is a known bug that sneaked in with b63. Plan is to release a new build in the coming days.

Any news on this by any chance ? :)

@vandalon
Copy link

Since b67 everything seems ok again. But, it seems that since ios 13 (this could be coincidence) that notifications take way longer to arrive, about 30 seconds. This is usually not an issue but I also connected a doorbell to HA (via gpio) and 30 seconds before a notification is a bit long for a doorbell :)

@mountainsandcode
Copy link

Indeed appears to be working fine - I don't have the issues with the delay however, they arrive pretty much instantly for me

@vandalon
Copy link

It seems, with the app open , notifications are instant. With iphone unlocked as well, When locked the delay seems to appear.

@TomBrien
Copy link
Member

I just did some testing with latest build (b68) and notifications contains text only are almost instant (never more than 2 seconds delay), notifications with images can take a while longer I've certainly seen 30 seconds. Test scenario was phone locked without HA Companion App running in the background, so should be the worst case client side.

@vandalon
Copy link

vandalon commented Oct 19, 2019

Awesome test. I can also say that with the 1.51 version of the app (the current one in the app store) my doorbell notifications are close to instant. (with image).

@TomBrien
Copy link
Member

2.0 uses a different service for notifications so that could be the root cause. Can you create a new issue for this delay please? I think this issue can be closed and I'd prefer it not to get confused.

@vandalon
Copy link

#453

@lowrisk75

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests