Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 12 #153

Merged
merged 436 commits into from May 3, 2019
Merged

iOS 12 #153

merged 436 commits into from May 3, 2019

Conversation

robbiet480
Copy link
Member

@robbiet480 robbiet480 commented Sep 18, 2018

Had to start fresh from #115 because of how hard @blackgold9 has been killing it with auth API lately, making a merge impossible


As outlined on the forums this PR contains iOS 12 specific changes:

  • Remove iOS 9 support
    • Remove UIApplication notification support
  • Update deps
  • Swift 4.2 5 migration
  • mobile_app integration
  • Remove legacy API password support
  • Notification enhancements
    • Critical Alerts
      • Code added
      • Entitlement Requested
      • Entitlement Received
    • Notification Settings deep link
    • Notification grouping enhancements (set thread ID on every notification generated by the app for native grouping, leave other groups up to users)
    • Duplicate categories
    • Actionable notification configuration in-app
  • Siri Shortcuts
    • Send Location
      • Default behavior is send current location
      • Check pasteboard for lat,long or address to geocode
    • Call Service
      • Allow setting just service name or service name + payload
      • If no payload set use pasteboard contents
    • Fire Event
      • Allow setting event name or event name + payload
    • Get image from camera proxy
      • Put it on pasteboard
    • Render template
  • Apple Watch
    • Complications support
    • App for actions
    • Watch can make API requests natively
    • Map and Camera interactive notifications
  • Today widget
    • Allow calling same actions as Watch
  • New data in updates
    • Pedometer data
    • Connection information including SSID, BSSID and connection type
    • Geocoded placemark
    • Timezone
  • Theme support
  • X-Callback-URL
    • Expose services for other apps
    • Support a Shortcut payload in notifications to open a shortcut and report back status see also
  • Alternate icons
  • Localization updates
    • Uploaded to Lokalise
    • All strings updated as needed
      • Siri Intent Definition File
  • Documentation
    • Siri Shortcuts
      • Examples
    • Notifications

@robbiet480 robbiet480 mentioned this pull request Sep 18, 2018
15 tasks
@robbiet480
Copy link
Member Author

Putting this here since it's now the 4th time i'm submitting for the critical alerts entitlement and don't want to write it again.

Home Assistant for iOS is the companion app to Home Assistant, a open source home automation that puts local control and privacy first. Its primary functions are providing location updates to Home Assistant and allowing users to send rich push notifications from Home Assistant to their devices.
The app doesn't send any notifications on its own. Users are entirely in control of what notifications are sent, when they are sent, and what they contain. It will be up to the users to decide if they should send a notification as a critical alert. Some examples of critical alerts that users may set up are the garage door being left open after they are detected as in bed or a glass break sensor detecting a intrusion.
Home Assistant powers peoples homes and keeps them safe and secure. Users need to be able to get critical and timely alerts for things like water leaks or unexpected motion. It will be entirely up to the end users discretion on when to use critical alerts.

@homeassistant
Copy link
Contributor

Hello @robbiet480,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@robbiet480
Copy link
Member Author

lol

@robbiet480
Copy link
Member Author

1.5.1 is finally out the door, so time to merge this bad boy into master!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants