Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target temperature in climate entity info window - dual setpoint visible when should be hidden #4359

Closed
oandrew opened this issue Dec 17, 2019 · 0 comments · Fixed by #4842
Closed
Assignees
Labels
Bug Current Bug in UI - Extra Attention

Comments

@oandrew
Copy link

oandrew commented Dec 17, 2019

both single and dual target temperature controls are displayed when only one should be visible at a time.

Screen Shot 2019-12-17 at 1 05 45 PM

I suspect the bug was caused by #4300 which was an attempt to fix #4296 .

For instance, when thermostat is in the single setpoint mode in has attributes:

temperature: 68
target_temp_high: null
target_temp_low: null

stateObj.attributes.target_temp_low !== undefined evalutes to true and makes all temperature controls visible even if they are null.

Looks like it should compare to null instead e.g. stateObj.attributes.target_temp_low != null. This way it will be hidden when undefined and still visible when it's 0 (#4296)

@oandrew oandrew added the Bug Current Bug in UI - Extra Attention label Dec 17, 2019
@bramkragten bramkragten self-assigned this Dec 17, 2019
bramkragten added a commit that referenced this issue Feb 11, 2020
bramkragten added a commit that referenced this issue Feb 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Current Bug in UI - Extra Attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants