New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve custom panel support #1236
Conversation
src/panels/custom/ha-panel-custom.js
Outdated
tempA.href = panel.config.html_url || panel.config.js_url; | ||
|
||
if (!panel.config.trust_external && !['localhost', '127.0.0.1', location.hostname].includes(tempA.hostname)) { | ||
if (!confirm(`Do you trust the external panel "${panel.config.name}" at "${tempA.href}"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik confirm does not work on mobile Safari or the iOS App
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in iOS 7.0.3 according to this StackOverflow.
|
Ok, fair point. I have an idea how to fix it. It means that we're going to keep panel config as |
👍 done! |
Add support for:
Backend PR home-assistant/core#14708
Starter kit example for React based panel: https://github.com/home-assistant/custom-panel-starter-kit-react
Config example: