On Safari 10 constructor check is broken #237
Conversation
|
@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @turbokongen and @persandstrom to be potential reviewers. |
| @@ -42,7 +42,11 @@ | |||
| }, | |||
|
|
|||
| _maybeLoadCustomUi: function (stateType) { | |||
| var isLoaded = this._isLoaded('STATE-CARD-' + stateType.toUpperCase()); | |||
| // Constructor check doesn't work on Safari 10. | |||
| // Bypassing this check mean that in order to user a built-in | |||
There was a problem hiding this comment.
Wait, this means that it is broken by default for Safari 10 users?
There was a problem hiding this comment.
Yes, custom UI didn't work on Safari 10.
Yesterday someone lend me their browserstack account so I could debug it.
We could remove the isLoaded check altogether. The reason I put it in in the first place was to allow using built-in components as custom UI. I guess it is a very edge-case, and is still possible by placing an empty "custom" html to prevent loading error.
There was a problem hiding this comment.
We should not allow people to use built-in components as custom ui. We should remove that functionality completely.
Same changes as were made in home-assistant/developers.home-assistant#490
On Safari 10 don't compare constructors when checking if custom UI element is loaded.
That check doesn't work (always says "loaded")