icon_color option for entities

[iantrich]

partial for #3897

Wanting to get feedback on supporting icon_color how hs_color was supported or if something else should be pursued.

Docs: TODO

[bramkragten]

What format would this config be in?

[bramkragten]

We still need to have a good strategy for colouring icons btw

[iantrich]

What format would this config be in?

icon_color:
  - 200 // hue
  - 100 // sat

which I don't particular like

[iantrich]

We still need to have a good strategy for colouring icons btw

what do you mean by this?

[bramkragten]

What format would this config be in?

icon_color:
  - 200 // hue
  - 100 // sat

which I don't particular like

No that kinda sucks

[bramkragten]

We still need to have a good strategy for colouring icons btw

what do you mean by this?

We should have a strategy for giving colors to state icons, like in what state what color. Like we have for lights and switches now, and has been asked for the other domains.

[iantrich]

We should have a strategy for giving colors to state icons, like in what state what color. Like we have for lights and switches now, and has been asked for the other domains.

Something to be tackled with a theming refactoring, I think. Personally I think "on" should just be active color for everything, I didn't really care for the whole "sun" reasoning

[bramkragten]

We should have a strategy for giving colors to state icons, like in what state what color. Like we have for lights and switches now, and has been asked for the other domains.

Something to be tackled with a theming refactoring, I think. Personally I think "on" should just be active color for everything, I didn't really care for the whole "sun" reasoning

It is not about theming, it is about the discussion in:
#2398
#1716
#2431

[iantrich]

It is not about theming, it is about the discussion in:

It is partially about theming as if we split sun-active vs regular-active it will be another css var. Like I said, I think on should just be on...

[iantrich]

regardless of the outcome of that discussion, I would still like to introduce icon_color

[Misiu]

@iantrich sorry if this is noob question, but will this change allow setting color based on state? For example in template sensor I'd like to have 2 states, so I'd like to be able to specify a icon color template that will return color based on my condition, similar to icon template. Hope this will be possible.

[iantrich]

@Misiu no, it is just a static option

[arsaboo]

Hopefully, the dynamic option will come soon after 😉

[Mariusthvdb]

Hopefully, the dynamic option will come soon after 😉

+1 to that!

Adding to that, it would be one of the most sought after features to implement in the backend for customize: Have the possibility to set icon_color (and even better, have the option of using a template) for all entities....
If that would be done, Lovelace cards would simply inherit the color setting for the icon....

[Misiu]

There is icon_template, there should be icon_color_template.
This shouldn't be hard, because icon_template already works.
@arsaboo @iantrich where should we address this? In which repo? https://github.com/home-assistant/home-assistant?
I've searched that repo for icon_template string and found only a couple of places.
Adding icon_color_template should look almost identical?

Sorry for all those questions - I'm still new to HA and just starting with Python.

[bramkragten]

I'm thinking about this a bit more, but this should be done in themes, like all styling. And we already have a state-icon-color or iron-icon-fill-color theme option, so this is already possible?

[iantrich]

How do you theme per entity on an entities card?

[bramkragten]

I was still at the entity_button this started with... 😛 but we should not mix this. Theming should be done with themes, so set a theme per entity might be bit overkill? Giving icons active colors based on states is something we can discuss.

[iantrich]

My concern with going the theme route for active/inactive is that it is not always that clear cut and your themes are going to be a disaster trying to handle edge cases/different views/cards.

e.g. a weather alert sensor.
no alerts: green
weather watch alert: yellow
weather warning alert: red

Theming that sounds difficult and non-intuitive. That may keep individual our element code a little bit simpler, but it makes configuration of each card/entity much more difficult for a user.

And on the topic of per-entity; I do see a need for it and is far from overkill.
e.g. motion in my bedroom when the alarm is set vs motion at my front door when the alarm is set. They are the same type of sensor, but their importance, which I might want to signify via color, is very different.

[Misiu]

@bramkragten I don't know if this is related, but I've created PR that adds support for icon_color_template that could be used to set icon color similar way we can set icon.
home-assistant/core#27455

[iantrich]

@Misiu that looks great for power users looking to do some really heavy lifting; but if I just want a single icon to be purple, I should be able to make it purple without grabbing a custom card or setting up a backend template.