Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃拕 match alarm panel icon coloring to card's #4825

Merged
merged 1 commit into from Feb 10, 2020

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Feb 10, 2020

Breaking change

Proposed change

Match the icon state-coloring to what is found in the alarm panel card

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Peek 2020-02-10 10-13

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it.

@balloob balloob merged commit 981c798 into home-assistant:dev Feb 10, 2020
@iantrich iantrich deleted the alarm-state-color branch February 10, 2020 17:04
@bramkragten bramkragten mentioned this pull request Feb 12, 2020
@lock lock bot locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active icon states color options
3 participants