Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary_sensor.enocean: document button events #2145

Merged
merged 3 commits into from Mar 8, 2017

Conversation

jannau
Copy link
Contributor

@jannau jannau commented Feb 25, 2017

The key events of this binary_sensor are not easily discovered. So better describe them explicitly.

Add documentation for the generated button_press events of the switch.
@mention-bot
Copy link

@jannau, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rubund, @fabaff and @mnoorenberghe to be potential reviewers.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment looks good.

id: [0xYY, 0xYY, 0xYY, 0xYY]
pushed: 0
action:
service_template: "{% if trigger.event.data.onoff %} light.turn_on {% else %} light.turn_off {%endif %}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid render of the template, use {% raw %}{{your_template}}{% endraw %}.

@Landrash
Copy link
Contributor

Landrash commented Mar 8, 2017

Thanks 🍸

@Landrash Landrash merged commit 3695c23 into home-assistant:next Mar 8, 2017
@jannau jannau deleted the enocean_binary_doc branch March 12, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants