Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/central scene documentation #3288

Merged
merged 7 commits into from Sep 1, 2017

Conversation

AddoSolutions
Copy link
Contributor

@AddoSolutions AddoSolutions commented Aug 31, 2017

Description:
This is documentation for the PR home-assistant/core#9178 allowing OpenZwave CentralScene handling.

Pull request in home-assistant (if applicable): home-assistant/core#9178

Copy link
Contributor

@emlove emlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in to help out! Some feedback below.

@@ -180,6 +180,36 @@ automation:
scene_id: 11
```

Some devices (like the HomeSeer wall switches) allow you to do things like double, and triple click the up and down buttons and fire an event. This does support the OpenZwave CentralScene handler. This is an example of double clicking the on/up button:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than "This does support the OpenZwave CentralScene handler.", I'd prefer "These devices will also send scene_data to differentiate the events." The users aren't too concerned with the underlying command class.

scene_data: 3
event_type: zwave.scene_activated
platform: event
action:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the action portion here to keep it consistent with the rest of the examples. It'll just be an example of the trigger portion.

entity_id: group.kitchen
```

For the HomeSeer devices specifically, you may need to update the `COMMAND_CLASS_CENTRAL_SCENE` for each node in your `zwcfg` file with the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move all the HomeSeer specific info into the device-specific page. (For reference: https://home-assistant.io/docs/z-wave/device-specific/ )

We can put a short note in here linking to that section.

@AddoSolutions
Copy link
Contributor Author

One moment and I will get those updated

- event_type: zwave.scene_activated
platform: event
event_data:
entity_id: light.diningroomcans_level

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AddoSolutions - The only change I'd recommend is that the entity_id here is sent as the zwave entity, not the value entity. For example, my HomeSeer dimmer will send the event from zwave.kitchen_lights not light.kitchen_lights_level.

The *object_id* and *scene_id* of all triggered events can be seen in the console output.

For more information on HomeSeer devices and similar devices, please see the [device specific page](https://home-assistant.io/docs/z-wave/device-specific/#aeon-minimote)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the anchor from #aeon-minimote to #homeseer-switches. Also please add a period at the very end of this line to end the sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I am just getting excited an missing dumb stuff. Sorry about that!

Also tweaking a few bit of the examples and a few other silly mistakes
- event_type: zwave.scene_activated
platform: event
event_data:
entity_id: zwave.diningroomcans_level

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave off the "_level", as that's part of the value entity. The entity_id sent with the event would just be zwave.diningroomcans in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are things I would have had to learn as I was actually implementing it. Thanks!

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR is merged.

@pvizeli pvizeli merged commit b6e145f into home-assistant:next Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants