Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZHA "OTA firmware updates" section is outdated #32003

Open
cremor opened this issue Mar 22, 2024 · 6 comments
Open

ZHA "OTA firmware updates" section is outdated #32003

cremor opened this issue Mar 22, 2024 · 6 comments

Comments

@cremor
Copy link

cremor commented Mar 22, 2024

Feedback

The section "OTA firmware updates" should be updated to mention the updates via the HA UI which are available since HA 2024.2

URL

https://www.home-assistant.io/integrations/zha/

Version

2024.3.2

Additional information

Please also update which manufacturer are supported - and which of those are enabled by default. See https://github.com/zigpy/zigpy/blob/dev/zigpy/config/defaults.py#L26

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this feedback as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the feedback.
  • @home-assistant rename Awesome new title Renames the feedback.
  • @home-assistant reopen Reopen the feedback.
  • @home-assistant unassign zha Removes the current integration label and assignees on the feedback, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information) to the feedback.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information) on the feedback.

@cremor
Copy link
Author

cremor commented Mar 22, 2024

Looks like there is already a PR for this: #28895

@Hedda
Copy link
Contributor

Hedda commented Apr 30, 2024

Looks like there is already a PR for this: #28895

Yes, but review(s) with feedback/input is needed as originally submited 12th of September 2023 -> #28895

@erkr
Copy link

erkr commented May 2, 2024

Please spent some time updating the OTA documentation. I really like to know what are the correct usage in 2024.5+.

@Hedda
Copy link
Contributor

Hedda commented May 3, 2024

@erkr You can review and post feedback in this open pull request here which aims to at least try to update OTA documentation:

Again, that PR was originally submitted in the beginning of September 2023 but I did update/rewrite it a couple of months ago.

So I did already spend time updating the OTA documentation but it does get outdated when new PRs are not quickly reviewed.

Note that PR reviews can be done by anyone, everybody can help out reviewing PRs and it is encouraged that you do so too, see:

https://developers.home-assistant.io/docs/review-process/

FYI, GitHub has instructions here on how-to comment on a pull request:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request

@erkr
Copy link

erkr commented May 3, 2024

@Hedda
As I'm not knowledgeable on the new OTA implementation, my review only covers if the new OTA description is understandable. Yes it looks good for me. It answered several of my questions 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants