requested changes

homeassistant/components/smarty/__init__.py

@@ -52,6 +52,7 @@ def setup(hass, config):
     # Load platforms
     discovery.load_platform(hass, 'fan', DOMAIN, {}, config)
     discovery.load_platform(hass, 'sensor', DOMAIN, {}, config)
+    discovery.load_platform(hass, 'binary_sensor', DOMAIN, {}, config)
 
     def poll_device_update(event_time):
         """Update Smarty device."""

homeassistant/components/smarty/binary_sensor.py

@@ -0,0 +1,69 @@
+"""Support for Salda Smarty XP/XV Ventilation Unit Binary Sensors."""
+
+import logging
+
+from homeassistant.components.binary_sensor import BinarySensorDevice
+from . import DOMAIN
+from .sensor import SmartySensor
+
+DEPENDENCIES = ['smarty']
+
+_LOGGER = logging.getLogger(__name__)
+
+
+async def async_setup_platform(hass, config, async_add_devices,
+                               discovery_info=None):
+    """Set up the Smarty Binary Sensor Platform."""
+    smarty = hass.data[DOMAIN]['api']
+    name = hass.data[DOMAIN]['name']
+
+    sensors = [AlarmSensor(name, smarty),
+               WarningSensor(name, smarty),
+               BoostSensor(name, smarty)]
+
+    async_add_devices(sensors)
+
+
+class BoostSensor(SmartySensor, BinarySensorDevice):
+    """Boost State Binary Sensor."""
+
+    def __init__(self, name, smarty):
+        """Alarm Sensor Init."""
+        super().__init__(name='{} Boost State'.format(name),
+                         device_class=None,
+                         smarty=smarty)
+
+    def update(self) -> None:
+        """Update state."""
+        _LOGGER.debug('Updating sensor %s', self._name)
+        self._state = self._smarty.boost
+
+
+class AlarmSensor(SmartySensor, BinarySensorDevice):
+    """Alarm Binary Sensor."""
+
+    def __init__(self, name, smarty):
+        """Alarm Sensor Init."""
+        super().__init__(name='{} Alarm'.format(name),
+                         device_class=None,
+                         smarty=smarty)
+
+    def update(self) -> None:
+        """Update state."""
+        _LOGGER.debug('Updating sensor %s', self._name)
+        self._state = self._smarty.alarm
+
+
+class WarningSensor(SmartySensor, BinarySensorDevice):
+    """Warning Sensor."""
+
+    def __init__(self, name, smarty):
+        """Warning Sensor Init."""
+        super().__init__(name='{} Warning'.format(name),
+                         device_class=None,
+                         smarty=smarty)
+
+    def update(self) -> None:
+        """Update state."""
+        _LOGGER.debug('Updating sensor %s', self._name)
+        self._state = self._smarty.warning

homeassistant/components/smarty/sensor.py

@@ -4,16 +4,13 @@
 import logging
 
 from homeassistant.core import callback
-from homeassistant.components.binary_sensor import BinarySensorDevice
-from homeassistant.components.smarty import (
-    DOMAIN, SIGNAL_UPDATE_SMARTY)
 from homeassistant.const import (
     TEMP_CELSIUS, DEVICE_CLASS_TEMPERATURE,
-    DEVICE_CLASS_TIMESTAMP,
-    STATE_ON, STATE_OFF)
+    DEVICE_CLASS_TIMESTAMP)
 import homeassistant.util.dt as dt_util
 from homeassistant.helpers.dispatcher import async_dispatcher_connect
 from homeassistant.helpers.entity import Entity
+from . import (DOMAIN, SIGNAL_UPDATE_SMARTY)
 
 DEPENDENCIES = ['smarty']
 
@@ -31,10 +28,7 @@ async def async_setup_platform(hass, config, async_add_devices,
                OutdoorAirTemperatureSensor(name, smarty),
                SupplyFanSpeedSensor(name, smarty),
                ExtractFanSpeedSensor(name, smarty),
-               AlarmSensor(name, smarty),
-               WarningSensor(name, smarty),
-               FilterDaysLeftSensor(name, smarty),
-               BoostSensor(name, smarty)]
+               FilterDaysLeftSensor(name, smarty)]
 
     async_add_devices(sensors)
 
@@ -168,51 +162,6 @@ def update(self) -> None:
         self._state = self._smarty.extract_fan_speed
 
 
-class BoostSensor(SmartySensor, BinarySensorDevice):
-    """System State Sensor."""
-
-    def __init__(self, name, smarty):
-        """Alarm Sensor Init."""
-        super().__init__(name='{} Boost State'.format(name),
-                         device_class=None,
-                         smarty=smarty)
-
-    def update(self) -> None:
-        """Update state."""
-        _LOGGER.debug('Updating sensor %s', self._name)
-        self._state = self._smarty.boost
-
-
-class AlarmSensor(SmartySensor, BinarySensorDevice):
-    """Alarm Sensor."""
-
-    def __init__(self, name, smarty):
-        """Alarm Sensor Init."""
-        super().__init__(name='{} Alarm'.format(name),
-                         device_class=None,
-                         smarty=smarty)
-
-    def update(self) -> None:
-        """Update state."""
-        _LOGGER.debug('Updating sensor %s', self._name)
-        self._state = STATE_ON if self._smarty.alarm else STATE_OFF
-
-
-class WarningSensor(SmartySensor, BinarySensorDevice):
-    """Warning Sensor."""
-
-    def __init__(self, name, smarty):
-        """Warning Sensor Init."""
-        super().__init__(name='{} Warning'.format(name),
-                         device_class=None,
-                         smarty=smarty)
-
-    def update(self) -> None:
-        """Update state."""
-        _LOGGER.debug('Updating sensor %s', self._name)
-        self._state = STATE_ON if self._smarty.warning else STATE_OFF
-
-
 class FilterDaysLeftSensor(SmartySensor):
     """Filter Days Left."""
 

requirements_all.txt

@@ -1,4 +1,4 @@
-/ Home Assistant core
+# Home Assistant core
 aiohttp==3.5.4
 astral==1.10.1
 async_timeout==3.0.1