Skip to content

Commit

Permalink
Update config entry id in entity registry (#15531)
Browse files Browse the repository at this point in the history
  • Loading branch information
balloob committed Jul 19, 2018
1 parent 2a76a08 commit 8b04d48
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
16 changes: 16 additions & 0 deletions homeassistant/helpers/entity_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,12 @@ def async_get_or_create(self, domain, platform, unique_id, *,
"""Get entity. Create if it doesn't exist."""
entity_id = self.async_get_entity_id(domain, platform, unique_id)
if entity_id:
entry = self.entities[entity_id]
if entry.config_entry_id == config_entry_id:
return entry

self._async_update_entity(
entity_id, config_entry_id=config_entry_id)
return self.entities[entity_id]

entity_id = self.async_generate_entity_id(
Expand All @@ -129,13 +135,23 @@ def async_get_or_create(self, domain, platform, unique_id, *,
@callback
def async_update_entity(self, entity_id, *, name=_UNDEF):
"""Update properties of an entity."""
return self._async_update_entity(entity_id, name=name)

@callback
def _async_update_entity(self, entity_id, *, name=_UNDEF,
config_entry_id=_UNDEF):
"""Private facing update properties method."""
old = self.entities[entity_id]

changes = {}

if name is not _UNDEF and name != old.name:
changes['name'] = name

if (config_entry_id is not _UNDEF and
config_entry_id != old.config_entry_id):
changes['config_entry_id'] = config_entry_id

if not changes:
return old

Expand Down
13 changes: 12 additions & 1 deletion tests/helpers/test_entity_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ def test_loading_saving_data(hass, registry):
# Ensure same order
assert list(registry.entities) == list(registry2.entities)
new_entry1 = registry.async_get_or_create('light', 'hue', '1234')
new_entry2 = registry.async_get_or_create('light', 'hue', '5678')
new_entry2 = registry.async_get_or_create('light', 'hue', '5678',
config_entry_id='mock-id')

assert orig_entry1 == new_entry1
assert orig_entry2 == new_entry2
Expand Down Expand Up @@ -191,3 +192,13 @@ def test_async_get_entity_id(registry):
assert registry.async_get_entity_id(
'light', 'hue', '1234') == 'light.hue_1234'
assert registry.async_get_entity_id('light', 'hue', '123') is None


async def test_updating_config_entry_id(registry):
"""Test that we update config entry id in registry."""
entry = registry.async_get_or_create(
'light', 'hue', '5678', config_entry_id='mock-id-1')
entry2 = registry.async_get_or_create(
'light', 'hue', '5678', config_entry_id='mock-id-2')
assert entry.entity_id == entry2.entity_id
assert entry2.config_entry_id == 'mock-id-2'

0 comments on commit 8b04d48

Please sign in to comment.