Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic snips intent (HassTurnOn/HassTurnOff) no longer is correctly processed #14918

Closed
FourierTransformer opened this issue Jun 11, 2018 · 2 comments · Fixed by #15246
Closed

Comments

@FourierTransformer
Copy link

Home Assistant release with the issue: 0.71.0

Last working Home Assistant release (if known): 0.68 - I upgraded from .68 to .71

Operating environment (Hass.io/Docker/Windows/etc.): Hass.io running on Raspberry Pi

Component/platform: snips

Description of problem: I setup a snips intent (HassTurnOn and HassTurnOff) so I could use snips to turn things on or off. It was working fine, but now returns an error when an intent gets passed in.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

snips:
  probability_threshold: .6

NOTE: I did add probability_threshold after upgrading as I was trying to reduce the number of bad intents that were being handled.

Traceback (if applicable):

2018-06-10 20:41:54 INFO (MainThread) [homeassistant.helpers.intent] Triggering intent handler <ServiceIntentHandler - HassTurnOff>
2018-06-10 20:41:54 WARNING (MainThread) [homeassistant.helpers.intent] Received invalid slot info for HassTurnOff: extra keys not allowed @ data['site_id']
2018-06-10 20:41:54 ERROR (MainThread) [homeassistant.components.snips] Error while handling intent: HassTurnOff.
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/intent.py", line 59, in async_handle
    result = await handler.async_handle(intent)
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/intent.py", line 187, in async_handle
    slots = self.async_validate_slots(intent_obj.slots)
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/intent.py", line 142, in async_validate_slots
    return self._slot_schema(slots)
  File "/usr/lib/python3.6/site-packages/voluptuous/schema_builder.py", line 267, in __call__
    return self._compiled([], data)
  File "/usr/lib/python3.6/site-packages/voluptuous/schema_builder.py", line 587, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/usr/lib/python3.6/site-packages/voluptuous/schema_builder.py", line 425, in validate_mapping
    raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: extra keys not allowed @ data['site_id']
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/components/snips.py", line 139, in message_received
    hass, DOMAIN, intent_type, slots, request['input'])
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/intent.py", line 65, in async_handle
    'Received invalid slot info for {}'.format(intent_type)) from err
homeassistant.helpers.intent.InvalidSlotInfo: Received invalid slot info for HassTurnOff

Additional information:
I have snips running on a different device than home assistant. I bridge the MQTT from that device to home assistant and only share specific topics. I did not change this configuration between upgrades as it was working.

@shawnifoley
Copy link

same here. I reverted the following snips.py and its working again
27edbe5#diff-78c3047c0f5f4bba332a4cdc6f50b1e8

@FourierTransformer
Copy link
Author

I reverted to this version: e593117#diff-78c3047c0f5f4bba332a4cdc6f50b1e8

It looks like the changes made in #14315 caused the issues with site_id

@ghost ghost added the in progress label Jul 1, 2018
@ghost ghost removed the in progress label Jul 1, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants