Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lutron failure in 0.84.1 #19273

Closed
grantalewis opened this issue Dec 13, 2018 · 12 comments · Fixed by #19279
Closed

Lutron failure in 0.84.1 #19273

grantalewis opened this issue Dec 13, 2018 · 12 comments · Fixed by #19279
Assignees

Comments

@grantalewis
Copy link

grantalewis commented Dec 13, 2018

Home Assistant release with the issue: 0.84.1

Last working Home Assistant release (if known): 0.83.3

Operating environment (Hass.io/Docker/Windows/etc.): RPi3, Hass.io

Component/platform: https://www.home-assistant.io/components/lutron/

Description of problem:

Error while setting up platform lutron
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/lutron.py", line 23, in setup_platform
    dev = LutronLight(area_name, device, hass.data[LUTRON_CONTROLLER])
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/light/lutron.py", line 45, in __init__
    super().__init__(self, area_name, lutron_device, controller)
TypeError: __init__() takes 4 positional arguments but 5 were given

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

lutron:
  host: 192.168.1.225
  username: lutron
  password: integration

Traceback (if applicable):


Additional information:
Lutron RA2 has a static assigned IP.

@marchingphoenix
Copy link
Contributor

Please fill out the template.

@grantalewis
Copy link
Author

Please fill out the template.

Was in process, thanks.

@Petro31
Copy link
Contributor

Petro31 commented Dec 13, 2018

super().__init__(self, area_name, lutron_device, controller)

needs to change to

super(LutronLight, self).__init__(area_name, lutron_device, controller)

@marchingphoenix
Copy link
Contributor

Blame #18650

@grantalewis
Copy link
Author

I'm new to this process. Is there anything else I need to do to make sure this gets seen?

@marchingphoenix
Copy link
Contributor

Was already seen.
~phnx

@JonGilmore
Copy link
Contributor

any workaround for this currently? All ~90 of my lutron lights are down :( maybe downgrade hass?

@marchingphoenix marchingphoenix self-assigned this Dec 14, 2018
@marchingphoenix
Copy link
Contributor

marchingphoenix commented Dec 14, 2018

If you take the file from the linked commit https://github.com/marchingphoenix/home-assistant/commit/9ba07029738bbae1329e1723af69a79bfb7c3e29, add it to custom_components/light/ and restart you should be fixed.
Working on adding unit tests so this will be less likely to happen in the future. Need someone who has these devices to look at adding unit tests to this platform.

@ghost ghost added the in progress label Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
fabaff pushed a commit that referenced this issue Dec 14, 2018
* #19273: fix call to super()

* #19273: adjust to python3 standards.

* #19273: remove bad test.
@lsilva171
Copy link

After applying this fix, the issue remains on my system as can be seen below:

Fri Dec 14 2018 03:02:34 GMT-0500 (Eastern Standard Time)

Error while setting up platform lutron
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/light/lutron.py", line 23, in setup_platform
    dev = LutronLight(area_name, device, hass.data[LUTRON_CONTROLLER])
  File "/config/custom_components/light/lutron.py", line 46, in __init__
    self, area_name, lutron_device, controller)
TypeError: __init__() takes 4 positional arguments but 5 were given

@MartinHjelmare
Copy link
Member

The stacktrace still looks like the old code.

@marchingphoenix
Copy link
Contributor

had a mistake in the commit that was sent, use the latest file from the pr:
#19279

@lsilva171
Copy link

The latest file works.

Thanks for the fix

balloob pushed a commit that referenced this issue Dec 14, 2018
* #19273: fix call to super()

* #19273: adjust to python3 standards.

* #19273: remove bad test.
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this issue Dec 25, 2018
* home-assistant#19273: fix call to super()

* home-assistant#19273: adjust to python3 standards.

* home-assistant#19273: remove bad test.
@ghost ghost removed the platform: light.lutron label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants