SynologyDSM Sensor does not respect standard SCAN_INTERVAL option

[SiliconAvatar]

Home Assistant release with the issue:

0.92.1

Last working Home Assistant release (if known):
Unknown

Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io on ubuntu.
Component/platform:

SynologyDSM Sensor

Description of problem:
This sensor has a hardcoded 15 minute update time ("MIN_TIME_BETWEEN_UPDATES").

This component should use the standard SCAN_INTERVAL (Per the entity documentation) so this can overridden by the user.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

#scan_interval option has no effect, and still updates every 15 minutes
- platform: synologydsm
  host: !secret synology_ip
  username: !secret synology_user
  password: !secret synology_pass
  scan_interval: 60
  monitored_conditions:
    - cpu_total_load
    - memory_real_usage
    - volume_percentage_used

Traceback (if applicable):

N/A

Additional information:

[ssmithTaylor]

Nm, I see you're working on it already.

[pergolafabio]

Are you guys owner of Synology code? Can you also have a look at my issue? I need some kind of new variable to identify a Synology...

#22571

[SiliconAvatar]

Nm, I see you're working on it already.

Me?

No, I just hard coded it to a different value lol. I gave it a shot but wasn't able to get it working properly. I'd be happy to try your code though!

[ssmithTaylor]

Nm, I see you're working on it already.

Me?

No, I just hard coded it to a different value lol. I gave it a shot but wasn't able to get it working properly. I'd be happy to try your code though!

Could you give this a shot?

https://github.com/ssmithTaylor/home-assistant/blob/dev/homeassistant/components/synologydsm/sensor.py

[SiliconAvatar]

@ssmithTaylor
Just gave it a shot. It locked up the system and wouldn't allow it to boot.

Lots of errors, but I believe this is the important part:

  File "/config/custom_components/synologydsm/sensor.py", line 147, in SynoApi
    @Throttle(min_update_interval)
NameError: name 'min_update_interval' is not defined

[ssmithTaylor]

@ssmithTaylor
Just gave it a shot. It locked up the system and wouldn't allow it to boot.

Lots of errors, but I believe this is the important part:

  File "/config/custom_components/synologydsm/sensor.py", line 147, in SynoApi
    @Throttle(min_update_interval)
NameError: name 'min_update_interval' is not defined

I see my mistake, commited a fix, could you try one more time?

[SiliconAvatar]

commited a fix, could you try one more time?

I've loaded the new component. Good news is that it loads correctly now, and I get the warning that I'm using the synologydsm custom component.

Bad news is that with scan_interval set to 60, it still only updates every 15 minutes.
Below is my component config:

- platform: synologydsm
  host: !secret synology_ip
  username: !secret synology_user
  password: !secret synology_pass
  scan_interval: 60
  monitored_conditions:
    - cpu_total_load
    - memory_real_usage
    - network_up
    - network_down
    - volume_percentage_used
    - disk_temp

I've tried rebooting it a few times but the results have not changed.
You can see in the photo below that the scan interval has indeed slowed from 1 minute down to 15.
https://i.imgur.com/iYMAYEC.png

If I change line 24 to a hardcoded 1 min default ( MIN_TIME_BETWEEN_UPDATES = timedelta(minutes=1)) then it goes back to 1 minute updates.

[stale]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[SiliconAvatar]

This issue is not yet resolved.

Please keep open, as that's the point of an issue tracker, to track open issues.

[stale]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[kevin14389]

Why this issue has been close without yet resolved ?