Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Life360 integration missing 'Moving' and 'Driving' attributes #24698

Closed
Mariusthvdb opened this issue Jun 22, 2019 · 3 comments
Closed

new Life360 integration missing 'Moving' and 'Driving' attributes #24698

Mariusthvdb opened this issue Jun 22, 2019 · 3 comments

Comments

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Jun 22, 2019

Home Assistant release with the issue:

094.3 Hassio

Last working Home Assistant release (if known):

Custom component in its original state provided show_as_state, which has been left out in the new integration

Operating environment (Hass.io/Docker/Windows/etc.):

Hassio
Component/platform:

Life360 (previously custom component)
Description of problem:

show_as_state: driving, moving has been a main part of functionality provided by the original custom_component. Leaving that out now in the new integration causes configs relying on functionality that to break, hence moving to the standard component is causing a “deficiency."

please consider re-adding these very important attributes to the new integration, thanks for considering

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

device_tracker:
  - platform: life360_custom
    username: !secret life360_username
    password: !secret life360_password
    prefix: life360
    show_as_state: places, driving, moving
    driving_speed: 20
    interval_seconds: 12
    max_gps_accuracy: 200
    max_update_wait:
      minutes: 10
    add_zones: only_home
    time_as: device_or_local
    warning_threshold: 1
    error_threshold: 2

leaving out 'places' (see original tracker above) can be mitigated by using the HA zones, so that's not the issue at hand.

Additional information:
please see https://community.home-assistant.io/t/life360-device-tracker-platform/52406/1097?u=mariusthvdb for discussion in the community

@MartinHjelmare
Copy link
Member

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum. Thanks!

@Mariusthvdb
Copy link
Contributor Author

@MartinHjelmare
sorry to disagree here. Hope you let me explain more precisely why I chose to add it here, instead of filing a feature request.

As I've tried to explain in the link I provided, where this is discussed to full extent, this is clearly not a regular feature request.

The integration has been used by many users for a long time in its Custom component version.
Becoming an integration now has taken out the very much used and relied on functionality show_as_state, which causes breaking changes to many setups.

The author has warned us in the community, so we are aware of it. Nevertheless, it is still a breaking change. Maybe not a 'Bug' in the sense the integration is broken, but at the very least the new integration is causing a 'deficiency'.

Because of that, this should be more in its place here in the Github issue tracker, than on the community feature request thread.

Hope you will allow this after all,
thanks for considering.

@MartinHjelmare
Copy link
Member

I'm not valuing this feature request. I'm sure it would be very useful to have. It's still a feature request so it doesn't belong in our issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants