ISY994 Lights not showing dimmer slide in 0.36.1

[jbcodemonkey]

Make sure you are running the latest version of Home Assistant before reporting an issue.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:

Home Assistant release (hass --version):
0.36.1

Python release (python3 --version):
3.5.2+

Component/platform:
ISY

Description of problem:
ISY imported Lights do not show brightness slider below journal chart. Instead a dropdown labelled 'Effect' is in its place.

Expected:
Rolling back to 0.35.3 restored functionality.

Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

[jbcodemonkey]

@Teagan42 @rmkraus @fabaff @randellhodges @OverloadUT

Any of you try the latest release and observe the same?

[andrey-git]

@jbcodemonkey could you go to /dev-state and paste here all the attributes of this device?

Is this light/isy994.py ?

[andrey-git]

A change I have done for light UI in 36.x was to show the brightness slider if the device supports it via supported_features attribute and not if brightness attribute exists.
(This still doesn't explain the appearance of "Effects" header)

[jbcodemonkey]

Yes, light/isy994.py

Attributes for light.1dr_floods:
brightness: 127
friendly_name: Dining Room Floods
icon: mdi:spotlight-beam

[jbcodemonkey]

In light/isy994.py, there is:

@property
def supported_features(self):
    """Flag supported features."""
    return SUPPORT_BRIGHTNESS

[andrey-git]

Found the bug:
isy994 indeed declares supported_features but it overrides state_attributes without exporting it:

@property
def state_attributes(self):
    """Flag supported attributes."""
    return {ATTR_BRIGHTNESS: self.value}

in light/__init__.py 👍

    @property
    def state_attributes(self):
        """Return optional state attributes."""
        data = {}

        if self.is_on:
            for prop, attr in PROP_TO_ATTR.items():
                value = getattr(self, prop)
                if value is not None:
                    data[attr] = value

            if ATTR_RGB_COLOR not in data and ATTR_XY_COLOR in data and \
               ATTR_BRIGHTNESS in data:
                data[ATTR_RGB_COLOR] = color_util.color_xy_brightness_to_RGB(
                    data[ATTR_XY_COLOR][0], data[ATTR_XY_COLOR][1],
                    data[ATTR_BRIGHTNESS])
        else:
            data[ATTR_SUPPORTED_FEATURES] = self.supported_features

        return data

[andrey-git]

Created a Fix PR

[andrey-git]

@jbcodemonkey Your feedback is required on the fix PR

[rmkraus]

Hijacked @andrey-git's PR like a pirate. ☠️

[jbcodemonkey]

Tested with commit from 5433, works again. Thank you!!