Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zwave Fibaro FGRM222 Roller Shutter Controller has more than one type/id #6421

Closed
hogend opened this issue Mar 5, 2017 · 22 comments · Fixed by #6832
Closed

Zwave Fibaro FGRM222 Roller Shutter Controller has more than one type/id #6421

hogend opened this issue Mar 5, 2017 · 22 comments · Fixed by #6832

Comments

@hogend
Copy link

hogend commented Mar 5, 2017

Home Assistant release (hass --version):
0.39.3

Python release (python3 --version):
Python 3.5.3

Component/platform:
zwave

Description of problem:
I have two FGRM222; for one, switch is hidden and open/close is reversed; for the other, switch is still there and open/close is not reversed.

On a related note: should open/close not be a configurable option, since it is dependent on the wiring of the controller (I prefer to change software, not hardware)

Expected:
Both FGRM222 should behave the same

Additional info:
In components/zwave/workaround.py, only one type/id combination is used: 0301/1001.
There is, however, another type/id combination 0302/1000 for the FGRM222 (and I happen to have both; see also the openzwave file manufacturer_specific.xml. This is the case for a lot of fibaro devices).

@linuxlurak
Copy link

linuxlurak commented Mar 5, 2017

I think I ran into the same problem. I reported it here: https://community.home-assistant.io/t/cover-switches-reversed-since-0-39-0-0-39-2-fibaro-fgr-222/. Obviously I reached no one else with this problem at the community...

In my case I have 4 out of 5 shutters that are reverted suddenly. I suspect this problem occurred when I upgraded to 0.39.0. But not sure at all at the moment.

+1 👍 for @hogend for the idea of an option to select the up/down behavior. This was discussed here in 2014:
https://groups.google.com/forum/#!topic/openhab/IZMVP4BZTkU

As I understand it this option was implemented in openhab.

PS: It seems I have 3x 301 / 1001 and 2x 302 / 1001. In my case the combination with 302 / 1001 leads to inverted action.

@linuxlurak
Copy link

linuxlurak commented Mar 5, 2017

@hogend perhaps you can try this version of workaround.py: https://github.com/linuxlurak/home-assistant/commit/677fc96405413a9bbe12e8959868eccb22303d8c

In my case I had to comment out all workarounds in workaround.py concerning my fgrm-222 devices. I don't know if I have wired them correctly or wired all devices the wrong way around...

With workaround.py having the workaround set up only for 301 devices half of my shutters reacted wrond. with the commit in the link above all devices worked wrong. So for me I had to deactivate all workarounds.

Best solution would be to allow inverting operations for any zwave device separately at yaml-files level.

@hogend
Copy link
Author

hogend commented Mar 5, 2017 via email

@linuxlurak
Copy link

linuxlurak commented Mar 6, 2017

In home assistant (HASS) the up and down arrows show up when I stop the cover. HASS doesn't check the cover state in real time as I understand it. It takes quiet a moment untill the covercomponent detects the actual state.

image

I wonder why this workaround is necessary? Do you have your devices wired correctly?

@linuxlurak
Copy link

In general: What ist the point of this workaround.py concerning fibaro shutters?

@andrey-git
Copy link
Contributor

To know if you wired the shutters correctly click on the state card and operate the shutter via the slider.
If the slider behaves in-reverse than it the wiring.

(I'm not saying it shouldn't be fixed in software, just making sure what the problem is)

@linuxlurak
Copy link

3 out of 5 behave in-reverse. Perhaps I wired them wrong. Perhaps there are different versions of the manual ;) Just searching an excuse ;)

Some option to set a reverse state would be super nice! "reversed: true" would be handy.

@andrey-git
Copy link
Contributor

Yes, it implemented in #6762

However I wonder which Fibaro Shutter models should be added to the workaround in addition to the one already there (thats the model I have)

@linuxlurak
Copy link

Oh, wow! That's phantastic news ;) Thanks to you an @turbokongen!

I have only those two models stated above at the moment. I don't know of others, sorry.

@andrey-git
Copy link
Contributor

@linuxlurak
for a "correctly working" shutter either both buttons & slider should work correctly or (if physically reversed) both buttons & slider should be reversed.

A workaround is needed if buttons are not consistent with slider.

Are buttons consistent with slider on your devices (after you disabled the workaround)?

@linuxlurak
Copy link

Yes, after I disable the workaround they work correctly / the buttons are consistent with sliders.

The workaround only touches type 301 ID 1001 devices. So with activated workaround my 3 shutter devices act reversed. I push down, they go up.

The workaround does not touch type 302 ID 1001. I have two devices of this type and even with activated workaround those two act as they should.

I asked why this workaround is necessary because I never had any problems with inconsistencies till the workaround was introduced. So I was wondering what the background was since there was no reason for me to introduce the workaround. It's clear to me what the underlying reason for this workaround is. Just didn't see it was necessary to my situation.

If I can help pleas ask! And thanks again for your tremendous work!

@andrey-git
Copy link
Contributor

Now I'm confused: the workaround only reverses the buttons, it doesn't affect the slider.
Are you saying that with workaround disabled both the slider and the button work correctly?

@linuxlurak
Copy link

Oh, sorry. The one that is confused seems to be me ;)

I just upgraded now to 0.41.0. The workaround seems to be applied again (as it did after every upgrade). So I tested it and can confirm that if I click on the arrows they are reversed:
image

In the picture there are arrows. Are this the sliders mentioned by you? The physical switch in my wall works as usual (the workaround has no influence there of course ;) ).

The shutters show up as switch too. I hid them:

#Roller Shutters as switches
    switch.fibaro_system_fgrm222_roller_shutter_controller_2_switch_20_0:
      friendly_name: 'living shutter left'
      hidden: true

Are you talking about buttons of those switches? If so I'l unhide them and test it.

Sorry, I'm not up to date with those termini technici...

@andrey-git
Copy link
Contributor

If you click on the text "living shutter left" you get a "more info" window. In that window there is a slider that allows you to set a "precise" position.

Is that slider working normally or is it reversed?

@linuxlurak
Copy link

linuxlurak commented Mar 27, 2017

Ha, yes the sliders work as they should! I confused sliders with shutters...

image

I unhided the switches as mentioned above but can't find them anywhere... Are the somehow removed with new HASS versions?

@andrey-git
Copy link
Contributor

Are the sliders working in the correct directions for all 5 of your devices? Do you know the firmware version of the shutters?

I'm now thinking that enabling the workaround by type and Id was too wide...

@linuxlurak
Copy link

linuxlurak commented Mar 27, 2017

I did some tests.

Type 301:

  • devices that act reversed with workaround on
  • up arrow --> shutter goes down
  • down arrow --> shutter goes down
  • slider on the right (100) --> shutter goes up
  • slider on the left (0) --> shutter goes down
  • Z-Wave Lib Version: 3.52 (ZDK 4.54.2)
  • Application Version: 24.24 (<-- firmware version?)
  • Type 301 / ID: 1001
  • tested with 3 devices / Lib / App version same on all three devices

Type 302:

  • device work normally / not influenced by workaround
  • up arrow --> shutter goes up
  • down arrow --> shutter goes down
  • slider on the right (100) --> shutter goes up
  • slider on the left (0) --> shutter goes down
  • tested with 2 devices
  • Z-Wave Lib Version: 3.52 (ZDK 4.54.2)
  • Application Version: 25.25 (<-- firmware version? different from above!)
  • Type 302 / ID: 1000 (Type and ID different from above)

@linuxlurak
Copy link

linuxlurak commented Mar 27, 2017

Some screenshots from homeseer about Z-Wave details:

301 /1001 Devices:
301-links
301-rechts
301-schlafen

302 /1000 Devices:
302-diele
302-outdoor

@linuxlurak
Copy link

linuxlurak commented Mar 27, 2017

Another remark: since 0.41.0 on any click on an item or it's up/down buttons the splash screen / details come up. Pressing up results not in the shutter going up but opening the details window in the middle of the site...

Edit: Only covers are affected as far as I can see. Lights and switches work normally.

@andrey-git
Copy link
Contributor

Thank you for the detailed test!

I'll check the app version of my Shutter. If it is older than 24.24 than the best solution would be probably to limit the workaround to older versions.

@linuxlurak
Copy link

@andrey-git Do you know something about the detail panel always opening when klicking on a cover button? Should I open a new issue?

@andrey-git
Copy link
Contributor

My Fibaro is version 22.22 I'll figure a way to limit the workaround to 22 and below.

I made home-assistant/frontend#248 to fix more-info opening upon buttons click.

@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants