New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wink device offline status #861
Comments
I think that the notion of a device being online/reachable is something that should go into the Entity class so that all platforms can benefit from it. Probably just a property |
In the latest version of python-wink 0.4.1 I made a change in the state method to check for the connection = true. If that isn't set, the state is returned as false. This solves the problem for wink switch, bulbs, and the power strip. I agree that it would be nice to have the component greyed out. Should we continue with the python-wink change? If so, once it is pushed to pypi I will include the 0.4.1 in my PR for the power strips. |
Yeah, having Wink have support for showing things as off would be a good start. This change has to be applied to all Wink related platforms. Let's not put it in your powerstrip PR but a new one. Let's get the powerstrip one merged first. |
Currently the changes in python-wink 0.4.1 require no changes in HA. The only changes are for binary switches, and the change is in the python-wink state method. My logic was if a binary switch states its connection is false it is most likely powered off so return a state of false. |
👍 sounds good. |
@balloob I am working on adding in the available property to wink. What would you like to do about the front end? Just change the icon color or change the icon entirely? I noticed you mentioned adding a warning icon as well. Not sure I know how to do that, but I can look. |
Right now when a device is not available it will have its state set to unavailable and no state attributes will be published. I haven't given much thought yet how to threat it in the frontend. We have a couple of choices:
|
Closing this issue, #1570 completes the required PRs to display Wink devices as offline. |
Opening an issue/ feature request to discuss the need to display Wink device status (on-line / off-line)
Currently in the Wink app for iOS and Android if a device, for example, a light bulb is physically turned off the bulb will be displayed as off-line.
In Home-Assistant if a bulb is off-line, but the last state of the bulb was on-line then that light will still report into HA as being on. It would be nice to know the status of the light to know if it can be turned back on.
This is to discuss how the Wink device status should be displayed in HA. My original idea was to change the device's name to device_name + Off-line if that device was off-line and leave it as device_name if it was on-line. @balloob stated this wouldn't be a good idea, so if anyone has any other suggestion...
The text was updated successfully, but these errors were encountered: