Xiaomi Aqara: Remove/Add device service added #10150
Conversation
…eway to pair a new sub device within the next 30 seconds.
| gateway.write_to_hub(gateway.sid, **join_permission) | ||
| break | ||
| else: | ||
| _LOGGER.error('Unknown gateway sid: %s was specified.', gw_sid) |
There was a problem hiding this comment.
Should we add a persistent notification telling the user to press a button on the device with in 30s ?
There was a problem hiding this comment.
Good point! I will extend the PR.
| for xiaomi_aqara_service in SERVICE_TO_METHOD: | ||
| schema = SERVICE_TO_METHOD[xiaomi_aqara_service].get( | ||
| 'schema', XIAOMI_AQARA_SERVICE_SCHEMA) | ||
| service_handler = SERVICE_TO_METHOD[xiaomi_aqara_service].get('method') |
There was a problem hiding this comment.
This is wrong and has broken the Xiaomi Aqara component. You are passing a string as service handler instead of the actual service. If you would have run this code locally, you would have noticed this right away 🤔
There is no need to make it complicated and use SERVICE_TO_METHOD dict. Instead just directly register the services.
| if ring_id is None or gw_sid is None: | ||
| _LOGGER.error("Mandatory parameters is not specified.") | ||
| return | ||
| ring_id = int(call.data.get(ATTR_RINGTONE_ID)) |
There was a problem hiding this comment.
Why cast to int if schema already does this?
|
|
||
| ring_id = int(ring_id) | ||
| if ring_id in [9, 14-19]: |
There was a problem hiding this comment.
lol wut? 14-19 is not a range, it's -5
|
Come on people, we can do better than this. |
|
Put a fix in #10302 |
Description:
I have refactored the service handling and added some schema pre-validation by voluptuous. Furthermore two new service (add_device & remove_device) are introduced.
The service "add_device" enables the join_permission of the Xiaomi Gateway for 30 seconds.
The service "remove_device" removes a sub-device identified by the device address (f.e. 158d000xxxxxc2)
Related issue: fixes #9571
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3836