Add Discogs Sensor platform #10957
Add Discogs Sensor platform #10957
Conversation
|
Not really sure how to fix linting errors from Travis: Other components didn't seem to do this when importing asyncio |
| """Set up the discogs sensor.""" | ||
| token = config.get(CONF_TOKEN) | ||
|
|
||
| async_add_devices([DiscogsCollection(token)], True) |
There was a problem hiding this comment.
What happens if the token is not valid? I assume that there will be a traceback. It's preferred to check if the connection can be established, otherwise the users will end-up with a non-working platform.
There was a problem hiding this comment.
Ok, I'm not at all sure how to do this, but I'll give it a try someday this week!
There was a problem hiding this comment.
See DiscogsCollection#init which returns false if the user is not present
There was a problem hiding this comment.
I guess that with an invalid token a discogs_client.exceptions.HTTPError will be thrown. This will happen before init return. The whole setup of the discogs client should happen in setup().
There was a problem hiding this comment.
I'll try and check again but it probably won't be anytime soon.
|
|
||
| REQUIREMENTS = ['discogs_client==2.2.1'] | ||
|
|
||
| SCAN_INTERVAL = timedelta(seconds=7200) |
| """Initialize the sensor.""" | ||
| import discogs_client | ||
| discogs = discogs_client.Client( | ||
| 'HomeAssistantDiscogs/0.1.0', user_token=token) |
There was a problem hiding this comment.
Can you please use SERVER_SOFTWARE (from homeassistant.helpers.aiohttp_client import SERVER_SOFTWARE)?
There was a problem hiding this comment.
Instead of the 'HomeAssistantDiscogs' string?
The file header is missing which is a docstring. E.g., """
Support for stored record collections on Discogs.
For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/sensor.discogs/
""" |
|
|
||
| self._ds_user = discogs.identity() | ||
| self._state = None | ||
|
|
ghost
removed
the
Description:
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4138
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass