Fix inverted sensors on the concord232 binary sensor component #11261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
requested changes
Dec 21, 2017
| @@ -118,7 +118,7 @@ def name(self): | |||
| def is_on(self): | |||
| """Return true if the binary sensor is on.""" | |||
| # True means "faulted" or "open" or "abnormal state" | |||
| return bool(self._zone['state'] == 'Normal') | |||
| return bool(self._zone['state'] == 'Tripped') | |||
There was a problem hiding this comment.
I think you should check against 'Normal' according to the comment, since the zone can take multiple states that are not normal:
https://github.com/JasonCarter80/concord232/blob/5ec7987beb5fb6522322936fc52b4f0530b52eea/concord232/concord_commands.py#L129-L136
return bool(self._zone['state'] != 'Normal')There was a problem hiding this comment.
I updated it to reflect this change.
pvizeli
added a commit
that referenced
this pull request
Dec 21, 2017
* Revert "Adding MotionIP to BinarySensors for HMIP-SMI (#11268)" This reverts commit c94cc34. * Revert "Bugfix: 10509 - http is hard coded in plex sensor (#11072)" This reverts commit 901d4b5. * Revert "Fix handling zero values for state_on/state_off (#11264)" This reverts commit 2e4e3a4. * Revert "Fix inverted sensors on the concord232 binary sensor component (#11261)" This reverts commit b866687. * Revert "Proper Steam game names and small fixes (#11182)" This reverts commit 7faa940. * Revert "Bugfix homematic available modus (#11256)" This reverts commit 1d57958. * Revert "Fix detection of if a negative node is in use (#11255)" This reverts commit b28bfad. * Revert "added myself to become code owner for miflora and plant (#11251)" This reverts commit e068204. * Revert "Add workaround for running tox on Windows platforms (#11188)" This reverts commit 81f1a65. * Revert "Upgrade to new miflora version 0.2.0 (#11250)" This reverts commit 8efc4b5. * Revert "homematic: add username and password to interface config schema (#11214)" This reverts commit b4e2537. * Revert "Backup configuration files before overwriting (#11216)" This reverts commit 90e25a6.
balloob
pushed a commit
that referenced
this pull request
Jan 5, 2018
* Fix inverted sensors on the concord232 binary sensor component * Changed from == Tripped to != Normal
Merged
ghost
added
integration: concord232
and removed
platform: binary_sensor.concord232
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes the inverted sensors of the concord232 binary sensor component
Related issue (if applicable): fixes #10797
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass