iOS 10 should be served javascript_version:es5

[mnoorenberghe]

Description:

iOS 10 can't handle javascript_version: latest and it's detected as being able to support it. See #11234 and other reports on the forums.

Related issue (if applicable): fixes #11234

Example entry for configuration.yaml (if applicable):

frontend:
  javascript_version: auto

[amelchio]

It's not really working even on iOS 11, see #11201.

[balloob]

I can't repro it locally but can repro it on latest dev. We just merged a fix for Safari home-assistant/frontend#757 so I am going to update dev with that to see if that resolves it.

[balloob]

Dev updated: 0f914b4

[balloob]

Confirmed locally that this fixes it on Safari 11.01. I don't have access to Safari 10. @mnoorenberghe could you test the latest dev ?

[balloob]

Weird, now I can't get it to work on Safari 11 when loading it from my production instance (I run dev).

The weird thing is that it should work:

It complains that e does not contain the method includes. This is surprising because by looking at the screenshot, it's clear that e is defined on top in the const declaration (line 2). Looking at the value of e, it actually has picked up the e variable on the window object (used in adding polyfill)

CC @andrey-git

[balloob]

I have double checked, I am unable to confirm it locally 🤔

[balloob]

Here is the original, unminified, source code: https://github.com/home-assistant/home-assistant-polymer/blob/master/src/data/ha-state-history-data.html#L67-L69

[andrey-git]

We could rename the polyfill e to something longer so it won't collide.

[balloob]

I'll give it a try. The weird thing is that it shouldn't collide at all. Window is always the last scope to be checked.

[balloob]

I am going to fix this later but for now adjusted this PR to serve ES5 to all Safari browsers and will include this PR in 0.60.1. Sorry about being a bit slow on releasing a hotfix for this, babies, holidays, etc

[balloob]

Just a heads up for people following this issue: I am reverting this change in home-assistant/frontend#1398 as we changed to a new build pipeline and I am no longer unable to repro it. Will aim to include this in 0.73.