Updated generic thermostat to respect operation_mode and added away mode #11445

ciotlosm · 2018-01-04T07:56:33Z

Note

Reopened because of branch pollution. Original PR: #11325

Description:

Add away mode
Fixed Operation selection bug
Fixed error on startup, fixes Climate Generic Thermostat always generating error on HASS start #11273
Includes functionality in [WIP] Add away mode support for generic thermostat #11081 (that was original source for away_mode changes)

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4285

Example entry for `configuration.yaml` (if applicable):

climate:
  - platform: generic_thermostat
    name: Study
    heater: switch.study_heater
    target_sensor: sensor.study_temperature
    cold_tolerance: 0.3
    hot_tolerance: 0.3
    away_temp: 18

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

…sor state Added more tests to improve coverage and corrected again lint errors Fixed new test by moving to correct package Fixed bug not restoring away mode on restart

…ne for now

…perature

ciotlosm added 9 commits January 4, 2018 09:56

Updated generic thermostat to respect operation_mode and added away mode

248ce03

Updated tests to include away mode and corrected init problem for sen…

bdf0778

…sor state Added more tests to improve coverage and corrected again lint errors Fixed new test by moving to correct package Fixed bug not restoring away mode on restart

Added support for idle on interface through state

f8f5ef5

Added back initial_operation_mode and modified away_temp to be only o…

cdaf7de

…ne for now

Fixed houndci-bot errors

9a5f8e5

Added back check for None on restore temperature

6b2ec13

Fixed failing tests as well

b0e0193

Removed unused definitions from tests

c73186e

Added use case for no initial temperature and no previously saved tem…

c4ef125

…perature

homeassistant added platform: climate.generic_thermostat cla-signed labels Jan 4, 2018

balloobbot added the platform label Jan 4, 2018

Danielhiversen merged commit 3436676 into home-assistant:dev Jan 4, 2018

ciotlosm deleted the generic_thermostat_auto branch January 4, 2018 18:23

balloob mentioned this pull request Jan 11, 2018

0.61 #11589

Merged

fanthos mentioned this pull request Jan 23, 2018

[WIP] Add away mode support for generic thermostat #11081

Closed

2 tasks

home-assistant locked and limited conversation to collaborators May 29, 2018

ghost added integration: generic_thermostat and removed platform: climate.generic_thermostat labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated generic thermostat to respect operation_mode and added away mode #11445

Updated generic thermostat to respect operation_mode and added away mode #11445

ciotlosm commented Jan 4, 2018

Updated generic thermostat to respect operation_mode and added away mode #11445

Updated generic thermostat to respect operation_mode and added away mode #11445

Conversation

ciotlosm commented Jan 4, 2018

Note

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Example entry for `configuration.yaml` (if applicable):