Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python-wink version and multiple wink fixes/updates. #11833

Merged
merged 2 commits into from Jan 25, 2018
Merged

Update python-wink version and multiple wink fixes/updates. #11833

merged 2 commits into from Jan 25, 2018

Conversation

w1ll1am23
Copy link
Contributor

@w1ll1am23 w1ll1am23 commented Jan 20, 2018 •
edited

Description:

This PR does several things.

Fixes the following issues reported in the forums

  1. Nest cam sensors weren't showing up. (Fixed via python-wink update)
  2. Cover sometimes reports its state as None which results in a traceback when we multiply the decimal number by 100.
  3. Multiple people have reported issues getting a 401 back from the Wink API after a restart. I believe this is happening because the .wink.conf is only updated at shutdown and it is possible users may be shutting down incorrectly? Or there is a power outage? So this adds a call to write the .wink.conf every hour with the latest oauth credentials that are in memory.

Adds the following new features

  1. Display the kidde radio code set on the Wink hub in device attributes
  2. Added heat/cool on attributes for Wink thermostats that support this. (Sensi is the only one I know of) these will be true if the unit is physically heating or cooling not just set to heat or cool mode.
  3. Added clarification about which direction dip switches go for the Kidde radio code in the service details.

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@w1ll1am23 w1ll1am23 mentioned this pull request Jan 20, 2018
Merged
@w1ll1am23 w1ll1am23 merged commit 5123487 into home-assistant:dev Jan 25, 2018
@balloob balloob mentioned this pull request Jan 26, 2018
Merged
MartinHjelmare
MartinHjelmare reviewed Jan 26, 2018
View reviewed changes
homeassistant/components/cover/wink.py
if self.wink.state() is not None:
return int(self.wink.state()*100)
else:
return STATE_UNKNOWN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return None if not known.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, should I open a PR to fix that and request it get added to the 0.61 PR or just have it go in the following release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No rush. Make PR when you have time.

matemaciek pushed a commit to matemaciek/home-assistant that referenced this pull request Jan 27, 2018
@matemaciek-9ld
Merge remote-tracking branch 'upstream/master' into 9ld
4c60a3c 
* upstream/master: (465 commits)
  Update pyhomematic to 0.1.38 (home-assistant#11936)
  Implement Alexa temperature sensors (home-assistant#11930)
  Fixed rfxtrx binary_sensor KeyError on missing optional device_class (home-assistant#11925)
  Allow setting climate devices to AUTO mode via Google Assistant (home-assistant#11923)
  fixes home-assistant#11848 (home-assistant#11915)
  Add "write" service to system_log (home-assistant#11901)
  Update frontend to 20180126.0
  Version 0.62
  Allow separate command and state OIDs and payloads in SNMP switch (home-assistant#11075)
  Add ERC20 tokens to etherscan.io sensor (home-assistant#11916)
  Report scripts and groups as scenes to Alexa (home-assistant#11900)
  Minor fix to configuration validation and related log line. (home-assistant#11898)
  Multi-Room Support for Greenwave Reality (home-assistant#11364)
  Added Xeoma camera platform (home-assistant#11619)
  Improve foscam library exception support (home-assistant#11701)
  Iota wallet (home-assistant#11398)
  New venstar climate component (home-assistant#11639)
  Update python-wink version and multiple wink fixes/updates. (home-assistant#11833)
  Use API to discover Hue if no bridges specified (home-assistant#11909)
  Clarify emulated hue warning (home-assistant#11910)
  ...
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@andrey-git andrey-git Awaiting requested review from andrey-git

Assignees
No one assigned
Labels
cla-signed integration: wink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@w1ll1am23 @MartinHjelmare @homeassistant