Fix forecast display problem in Firefox #12073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-needed
merging-to-master
|
PRs can only be merged to |
|
It seems like you have some commits in this branch that are not yours, please clean it up. |
escoand
force-pushed
the
owm_forecast_timestamp
branch
from
ab3b921
to
f3c6170
Compare
houndci-bot
reviewed
Jan 30, 2018
| }) | ||
| if (len(data) - 1) % MIN_OFFSET_BETWEEN_FORECAST_CONDITIONS == 0: | ||
| data[len(data) - 1][ATTR_FORECAST_CONDITION] = \ | ||
| [k for k, v in CONDITION_CLASSES.items() if entry.get_weather_code() in v][0] |
There was a problem hiding this comment.
line too long (96 > 79 characters)
| ATTR_FORECAST_TEMP: entry.get_temperature('celsius').get('temp') | ||
| }) | ||
| if (len(data) - 1) % MIN_OFFSET_BETWEEN_FORECAST_CONDITIONS == 0: | ||
| data[len(data) - 1][ATTR_FORECAST_CONDITION] = \ |
There was a problem hiding this comment.
indentation is not a multiple of four
| for entry in self.forecast_data.get_weathers(): | ||
| data.append({ | ||
| ATTR_FORECAST_TIME: entry.get_reference_time('iso'), | ||
| ATTR_FORECAST_TEMP: entry.get_temperature('celsius').get('temp') |
There was a problem hiding this comment.
line too long (80 > 79 characters)
escoand
force-pushed
the
owm_forecast_timestamp
branch
from
f3c6170
to
2ea3baf
Compare
|
Recreated PR branch on dev. |
Danielhiversen
removed
the
merging-to-master
fabaff
changed the title
Merged
ghost
added
integration: openweathermap
and removed
platform: weather.openweathermap
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In Firefox the forecast chart is empty because of a not working timestamp format.
Related issue (if applicable): fixes #12055
Example entry for
configuration.yaml(if applicable):Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass