Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wakeonlan to 1.0.0 #12190

Merged
merged 1 commit into from Feb 6, 2018
Merged

Upgrade wakeonlan to 1.0.0 #12190

merged 1 commit into from Feb 6, 2018

Conversation

tadly
Copy link
Contributor

@tadly tadly commented Feb 5, 2018

Description:

Related issue (if applicable): fixes #11403

Pull request in home-assistant.github.io with documentation (if applicable):

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the PR template and address the points of the checklist.

@tadly
Copy link
Contributor Author

tadly commented Feb 5, 2018

Sorry, I missed the tests.
I force pushed the changes. Hope that's better now :)

@balloob
Copy link
Member

balloob commented Feb 6, 2018

Thanks! 🎉

@balloob balloob merged commit 98b47ce into home-assistant:dev Feb 6, 2018
@balloob balloob mentioned this pull request Feb 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wakeonelan dependency bug
4 participants