[WIP] HomeMatic KeyMatic works as a lock device #12384
Conversation
|
Hi @krys1976, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
| @@ -460,7 +462,8 @@ def _system_callback_handler(hass, config, src, *args): | |||
| ('cover', DISCOVER_COVER), | |||
| ('binary_sensor', DISCOVER_BINARY_SENSORS), | |||
| ('sensor', DISCOVER_SENSORS), | |||
| ('climate', DISCOVER_CLIMATE)): | |||
| ('climate', DISCOVER_CLIMATE), | |||
| ('lock', DISCOVER_LOCK)): | |||
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
There was a problem hiding this comment.
solved in newer commit
| ('sensor', DISCOVER_SENSORS), | ||
| ('climate', DISCOVER_CLIMATE) | ||
| ('lock', DISCOVER_LOCK)): | ||
| # Get all devices of a specific type |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
There was a problem hiding this comment.
solved in newer commit
| ('binary_sensor', DISCOVER_BINARY_SENSORS), | ||
| ('sensor', DISCOVER_SENSORS), | ||
| ('climate', DISCOVER_CLIMATE) | ||
| ('lock', DISCOVER_LOCK)): |
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
There was a problem hiding this comment.
solved in newer commit
|
Hope this push request works so far. |
| @@ -0,0 +1,858 @@ | |||
| """ | |||
There was a problem hiding this comment.
Is this components/homematic/__init__.py? If so, why did you copy it here?
There was a problem hiding this comment.
I checked out current master and made my changes. In current master, this file still exists. May be dropped if not needed.
| devices = [] | ||
| for conf in discovery_info[ATTR_DISCOVER_DEVICES]: | ||
| new_device = HMLock(conf) | ||
| devices.append(new_device) |
There was a problem hiding this comment.
devices.append(HMLock(conf))
There was a problem hiding this comment.
I did it the same way like in switch.homematic
| def _init_data_struct(self): | ||
| """Generate the data dictionary (self._data) from metadata.""" | ||
| self._state = "STATE" | ||
| self._data.update({self._state: STATE_UNKNOWN}) |
There was a problem hiding this comment.
I would just write self._data[self._state] = STATE_UNKNOWN (I know the other homematic devices do it your way, but this is just much easier to parse in your head)
There was a problem hiding this comment.
I did it the same way like in switch.homematic
| def update(self): | ||
| """Update state by device callback.""" | ||
| self._state = (STATE_LOCKED if self.is_locked() | ||
| else STATE_UNLOCKED) |
There was a problem hiding this comment.
I'm not a Lock component expert (nor a Homematic user), but I think this call is unnecessary because LockDevice already handles this for you:
There was a problem hiding this comment.
Oh ... sure .. ;-)
|
Maby you can merge it or address the comments from this like the is_open property. |
chrismanivong
changed the title
|
This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it. |
ghost
removed
the
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4665
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass