Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix homekit: temperature calculation #12720

Merged
merged 1 commit into from Feb 26, 2018
Merged

Fix homekit: temperature calculation #12720

merged 1 commit into from Feb 26, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 26, 2018 •
edited

Description:

Prevents potential errors with strings as temperature state (which aren't STATE_UNKNOWN).

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@pvizeli pvizeli added this to the 0.64.1 milestone Feb 26, 2018
@cdce8p
Copy link
Member Author

cdce8p commented Feb 26, 2018

@pvizeli Fix is only relevant for 0.64.1 if #12676 is merged into master.

@cdce8p cdce8p removed this from the 0.64.1 milestone Feb 26, 2018
@pvizeli pvizeli merged commit 6a665ff into home-assistant:dev Feb 26, 2018
@cdce8p cdce8p deleted the homekit-fix-calc-temp branch February 26, 2018 21:36
@balloob balloob mentioned this pull request Mar 9, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed integration: homekit small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdce8p @pvizeli @homeassistant