Round humidity for display purposes #12766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I don't think it's a good idea to rename the helper. It's overkill for humidity. This can just remain inside the weather component. It also doesn't need all the fancy rounding logic because there is only 1 unit which is treated the same. We should just add a round to this line: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/weather/__init__.py#L113 |
|
Well, yeah, if you want to be simple and efficient. Sheesh. 🙄 😄 |
PhilRW
force-pushed
the
weather_humidity_precision
branch
from
8feb97b
to
fea3cf4
Compare
Humidity was not being rounded as temperature was. This change fixes that.
PhilRW
force-pushed
the
weather_humidity_precision
branch
from
fea3cf4
to
c9f1b87
Compare
PhilRW
changed the title
Merged
ghost
added
integration: darksky
integration: wink
and removed
platform: climate.wink
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Humidity was not being rounded as temperature was. This change fixes that.
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass