Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update html5 to async/await tests #12896

Merged
merged 2 commits into from Mar 5, 2018

Conversation

perosb
Copy link
Contributor

@perosb perosb commented Mar 4, 2018

Description:

async/await syntax tests
tests for #12895

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

'notify': {
'platform': 'html5'
}
})

return (yield from test_client(hass.http.app))
return (await test_client(hass.http.app))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the parentheses here anymore:

return await test_client(hass.http.app)

@balloob balloob merged commit f00d5cb into home-assistant:dev Mar 5, 2018
@balloob balloob mentioned this pull request Mar 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
@perosb perosb deleted the notify-html5-async-tests branch March 10, 2019 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants