Remove weird tests #12936
Merged
Remove weird tests #12936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellerza
reviewed
Mar 6, 2018
| side_effect=mock_update_config | ||
| ), patch( | ||
| 'homeassistant.components.device_tracker.async_load_config', | ||
| side_effect=lambda *args: mock_coro(devices) |
There was a problem hiding this comment.
Are lambda function coroutines/do the inherit it in some way?
Lambda functions does not seem to be async yet according to PEP492
There was a problem hiding this comment.
Async functions return coroutines when called. These can be awaited to execute it and get the result. So in this case the lamda passes the coroutine to the caller.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
More test fixes.
Mediaroom test didn't test anything, was actually just running code and took on my machine 60 seconds.
The meraki tests were actually doing Mac vendor lookups 馃憥
(realized that this was also the problem with DDWRT tests but they are disabled now and can't be bothered to fix them)
Fixed flakiness of TestComponentsDeviceTracker.test_adding_unknown_device_to_config by removing all I/O from test
Related issue (if applicable): #12931