[SQL Sensor] partial revert of #12452 #12956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: sensor.sql
small-pr
balloob
approved these changes
Mar 6, 2018
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses:
https://community.home-assistant.io/t/sql-sensor-errors-after-upgrade-to-0-64-3/45969
#12452 moved close() to immediately after the query execution, and was validated with test against MySQL. This worked well for databases that have connection pools (everyone except SQLite).
Explanation of the problem can be traced to:
http://docs.sqlalchemy.org/en/latest/core/pooling.html#sqlalchemy.pool.NullPool
The current PR, moves the session close() back to after all objects related to sqlalchemy can be invalidated.
Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass