Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonos group discovery #12970

Merged
merged 2 commits into from Mar 8, 2018
Merged

Conversation

amelchio
Copy link
Contributor

@amelchio amelchio commented Mar 7, 2018

Description:

I did not test discovery: very well with the recent Sonos rework and it turns out that two races are possible because it adds devices one by one:

  • We could schedule_update_ha_state on a slave that was not yet async_added_to_hass.
  • Slaves discovered after their group coordinator were not linked properly.

Example entry for configuration.yaml (if applicable):

discovery:

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully.
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@balloob balloob merged commit 44e4f8d into home-assistant:dev Mar 8, 2018
@balloob balloob mentioned this pull request Mar 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants