Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request.query #13037

Merged
merged 1 commit into from Mar 10, 2018
Merged

Use request.query #13037

merged 1 commit into from Mar 10, 2018

Conversation

ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Mar 10, 2018

Description:

Use the correct api on request

Related issue (if applicable): fixes #13036

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @ptarjan,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob balloob added this to the 0.65.2 milestone Mar 10, 2018
@balloob
Copy link
Member

balloob commented Mar 10, 2018

Thanks! 🎉

@balloob balloob merged commit f9c1675 into home-assistant:dev Mar 10, 2018
balloob pushed a commit that referenced this pull request Mar 10, 2018
@balloob balloob mentioned this pull request Mar 10, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wink OAuth gives error
3 participants