Revert "Cast automatically drop connection (#12635)" #13094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TL;DR; Revert #12635 as a temporary workaround for #12968.
Some cast devices restart at night and cause the max retries logic to stop the connection, thus breaking some cast devices every night. The original purpose of #12635 was to not have to many stale socket clients around, that error has been in the integration for a long time and didn't cause issues of the same kind of magnitude as #12968. So I propose that we revert the automatically dropping connections while keeping the good parts of it (
PlatformNotReady
) for now.I'm working on a refactor for this platform where the
entity
is responsible for thepychromecast.Chromecast
objects but haven't had enough time to get that fully tested and ready. I hope to get that in the next major release. (+ then probably the release after that hopefully an even bigger cast platform refactor that would also make the integration finally async-aware...)Related issue (if applicable): fixes #12968
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: