Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cast automatically drop connection (#12635)" #13094

Merged
merged 1 commit into from Mar 11, 2018

Conversation

OttoWinter
Copy link
Member

@OttoWinter OttoWinter commented Mar 11, 2018

Description:

TL;DR; Revert #12635 as a temporary workaround for #12968.

Some cast devices restart at night and cause the max retries logic to stop the connection, thus breaking some cast devices every night. The original purpose of #12635 was to not have to many stale socket clients around, that error has been in the integration for a long time and didn't cause issues of the same kind of magnitude as #12968. So I propose that we revert the automatically dropping connections while keeping the good parts of it (PlatformNotReady) for now.

I'm working on a refactor for this platform where the entity is responsible for the pychromecast.Chromecast objects but haven't had enough time to get that fully tested and ready. I hope to get that in the next major release. (+ then probably the release after that hopefully an even bigger cast platform refactor that would also make the integration finally async-aware...)

Related issue (if applicable): fixes #12968

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: cast

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@OttoWinter OttoWinter added this to the 0.65.3 milestone Mar 11, 2018
@balloob balloob merged commit 1dc5fa1 into home-assistant:dev Mar 11, 2018
@balloob
Copy link
Member

balloob commented Mar 11, 2018

😢 always so many edge cases.

balloob pushed a commit that referenced this pull request Mar 11, 2018
@balloob balloob mentioned this pull request Mar 11, 2018
@OttoWinter OttoWinter deleted the cast-revert-disconnect branch March 13, 2018 19:15
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error - media_player / pychromcast
3 participants