Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Sonos error when joining with self #13196

Merged
merged 1 commit into from Mar 14, 2018

Conversation

amelchio
Copy link
Contributor

Description:

This fixes an error that could happen if we attempted to add an entity as its own slave.

2018-03-13 23:50:22 ERROR (SyncWorker_19) [homeassistant.components.media_player.sonos] Error on join with UPnP Error 402 received: Invalid Args from 10.0.2.14

Related issue (if applicable): reported in forum

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@amelchio amelchio added this to the 0.65.5 milestone Mar 13, 2018
@balloob balloob merged commit 7fc9ac0 into home-assistant:dev Mar 14, 2018
@balloob balloob mentioned this pull request Mar 14, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants