media_content_type attribute display fix #13204
Conversation
Kodi media_content_type attribute display fix
fixes attribute display for unknown media
homeassistant
added
platform: media_player.kodi
small-pr
|
Hi @kuzin2006, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
| @@ -481,7 +482,12 @@ def media_content_id(self): | |||
| @property | |||
| def media_content_type(self): | |||
| """Content type of current playing media.""" | |||
| return MEDIA_TYPES.get(self._item.get('type')) | |||
| """If item type is unknown to Kodi, return type of first player instead, if any""" | |||
| if MEDIA_TYPES.get(self._item.get('type')) is None and self._players: | |||
| @@ -481,7 +482,12 @@ def media_content_id(self): | |||
| @property | |||
| def media_content_type(self): | |||
| """Content type of current playing media.""" | |||
| return MEDIA_TYPES.get(self._item.get('type')) | |||
| """If item type is unknown to Kodi, return type of first player instead, if any""" | |||
There was a problem hiding this comment.
line too long (90 > 79 characters)
| @@ -61,6 +61,7 @@ | |||
| # https://github.com/xbmc/xbmc/blob/master/xbmc/media/MediaType.h | |||
| MEDIA_TYPES = { | |||
| 'music': MEDIA_TYPE_MUSIC, | |||
| 'audio': MEDIA_TYPE_MUSIC, | |||
There was a problem hiding this comment.
Let's put this at the bottom with a comment similar to channel explaining why it's included in this list, since it's not in the linked source list.
| return MEDIA_TYPES.get(self._item.get('type')) | ||
| """If item type is unknown to Kodi, return type of first player instead, if any""" | ||
| if MEDIA_TYPES.get(self._item.get('type')) is None and self._players: | ||
| content_type = MEDIA_TYPES.get(self._players[0]['type']) |
There was a problem hiding this comment.
Instead of assigning a variable, just return from these statements, i.e.:
return MEDIA_TYPES.get(self._players[0]['type'])
| return MEDIA_TYPES.get(self._players[0]['type']) | ||
| else: | ||
| return MEDIA_TYPES.get(self._item.get('type')) | ||
|
|
| return MEDIA_TYPES.get(self._item.get('type')) | ||
| """If item type is unknown to Kodi, | ||
| return type of first player instead, if any""" | ||
| if MEDIA_TYPES.get(self._item.get('type')) is None and self._players: |
| @@ -481,7 +483,13 @@ def media_content_id(self): | |||
| @property | |||
| def media_content_type(self): | |||
| """Content type of current playing media.""" | |||
| return MEDIA_TYPES.get(self._item.get('type')) | |||
| """If item type is unknown to Kodi, | |||
| @@ -60,7 +60,7 @@ | |||
|
|
|||
| # https://github.com/xbmc/xbmc/blob/master/xbmc/media/MediaType.h | |||
| MEDIA_TYPES = { | |||
| 'music': MEDIA_TYPE_MUSIC, | |||
| 'music': MEDIA_TYPE_MUSIC, | |||
| @@ -482,12 +483,13 @@ def media_content_id(self): | |||
| @property | |||
| def media_content_type(self): | |||
| """Content type of current playing media.""" | |||
| """If item type is unknown to Kodi, return type of first player instead, if any""" | |||
| """If item type is unknown to Kodi, | |||
There was a problem hiding this comment.
You'll want to keep a one line summary here, and then include more details later. Background and an example here. Something like this would work:
@property
def media_content_type(self):
"""Content type of current playing media.
If the media type cannot be detected, the player type is used.
"""Apologies for the nitpicking!
There was a problem hiding this comment.
oh, of course youre right ))
| """ | ||
| if MEDIA_TYPES.get(self._item.get('type')) is None and self._players: | ||
| return MEDIA_TYPES.get(self._players[0]['type']) | ||
| else: |
There was a problem hiding this comment.
Just in case it's not clear travis is complaining about this else. It's pointing out that we don't need the else here, we can just go right to the next return after the if block.
|
Awesome. Thanks for the contribution! 🌟 |
ghost
added
Kodi media_content_type attribute display fix
Description:
When Kodi can't retrieves media info, API call to Player.GetProperties returns item "type" "unknown" for some media (If you watch smth known to IMDB, for example, item type is "movie", but for home video it would be "unknown"). This causes media_player entity not to display media_content_type attribute for certain content, so actions using this attribute do not work properly in certain cases.
This fix displays Player type, if Item type not defined in MEDIA_TYPES.
Related issue (if applicable): fixes #6989
Checklist:
tox. Your PR cannot be merged unless tests pass