Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tado: don't reference unset hass var #13237

Merged
merged 1 commit into from Mar 15, 2018
Merged

Tado: don't reference unset hass var #13237

merged 1 commit into from Mar 15, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 15, 2018

Description:

Tado was referencing a non existing hass variable.

Related issue (if applicable): fixes #13179

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.65.6 milestone Mar 15, 2018
amelchio
amelchio approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should fix the exception in the linked issue.

However, the title seems like a leftover from before you realized that the loop= argument is not even needed.

@filcole
Copy link
Contributor

filcole commented Mar 15, 2018

Code fix makes the tado device tracker work again. Thanks!

@balloob balloob changed the title Tado needs to store hass as instance var Tado: don't reference unset hass var Mar 15, 2018
@balloob balloob merged commit 456ff4e into dev Mar 15, 2018
@balloob balloob deleted the fix-tado branch March 15, 2018 20:54
@balloob
Copy link
Member Author

balloob commented Mar 15, 2018

@amelchio haha yep, we're on Py35 now, no more passing loops around!

@pvizeli
Copy link
Member

pvizeli commented Mar 15, 2018

that is wrong

@balloob
Copy link
Member Author

balloob commented Mar 15, 2018

Why?

@balloob
Copy link
Member Author

balloob commented Mar 15, 2018

https://bugs.python.org/issue28613

@pvizeli
Copy link
Member

pvizeli commented Mar 15, 2018

We use different event loop and don't set this as default loop. Now it use the default loop they need not running. On windows i.e. it will now block forever

@pvizeli
Copy link
Member

pvizeli commented Mar 15, 2018 •
edited

oh nice. Ignore my comment :)

balloob added a commit that referenced this pull request Mar 21, 2018
@balloob
Tado: don't reference unset hass var (#13237)
7e08e8b 
Tado: don't reference unset hass var
@balloob balloob mentioned this pull request Mar 21, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amelchio amelchio amelchio approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: device_tracker small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.65.6
Development

Successfully merging this pull request may close these issues.

Tado Device tracker not working anymore
5 participants
@balloob @filcole @pvizeli @amelchio @homeassistant