Fix Sonos join/unjoin in scripts #13248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since #12126 the Sonos platform has relied exclusively on push events to determine the grouping of players. That is very clean and works perfectly ... in theory.
In practice, we have scripts that modify a group and start using a single speaker before any event tells us that it is now detached.
This PR sacrifices a bit of the cleanliness because actually working is also nice. We now update the group topology by hand when issuing group modifications. This happens under the existing
topology_lock
so we never construct any partial groups.The event handler is still needed because external controllers might also be modifying groups.
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
.If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.