Fixing Egardia 'home armed' state not shown correctly. #13335
Conversation
|
@MartinHjelmare Travis errors out on |
requirements_all.txt
Outdated
| @@ -1006,9 +1006,11 @@ python_opendata_transport==0.0.3 | |||
| python_openzwave==0.4.3 | |||
|
|
|||
| # homeassistant.components.egardia | |||
| # homeassistant.components.alarm_control_panel.egardia | |||
| pythonegardia==1.0.38 | |||
There was a problem hiding this comment.
This line should be removed. The script should handle that automatically. Did you run the script?
There was a problem hiding this comment.
I ran the script.
There was a problem hiding this comment.
Oh wait, I think I know the problem. Will fix tomorrow.
|
Ok, I think it looks better now. |
| from homeassistant.components.egardia import ( | ||
| EGARDIA_DEVICE, EGARDIA_SERVER, | ||
| REPORT_SERVER_CODES_IGNORE, CONF_REPORT_SERVER_CODES, | ||
| CONF_REPORT_SERVER_ENABLED, CONF_REPORT_SERVER_PORT | ||
| ) | ||
| REQUIREMENTS = ['pythonegardia==1.0.38'] | ||
| REQUIREMENTS = ['pythonegardia==1.0.39'] |
There was a problem hiding this comment.
This should be removed. The alarm platform should depend on the egardia component. Add a DEPENDENCIES list instead.
There was a problem hiding this comment.
should I add the DEPENDENCIES list to binary_sensor/egardia.py too? It is also a platform that depends on the egardia component..
|
ok to merge when you ran |
|
@balloob I did and I checked the changes it made manually and they look as expected. |
|
I doubt you did after making changes… you removed requirement from alarm control panel yet it's still listed as having one in requirements_all.txt |
|
@balloob weird, I ran it after the last changes, I am certain. I ran it again and now the changes are pickup up the way they need to be (afaik). |
|
👍 🐬 🎉 |
Description:
Fixing Python-egardia bug jeroenterheerdt/python-egardia#17: Home armed state was not showing correctly in Home Assistant. This PR replaces #13309
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: